Add ipv6 support for paloalto panos show routing route#2298
Open
lundgrenolof wants to merge 6 commits intonetworktocode:masterfrom
Open
Add ipv6 support for paloalto panos show routing route#2298lundgrenolof wants to merge 6 commits intonetworktocode:masterfrom
lundgrenolof wants to merge 6 commits intonetworktocode:masterfrom
Conversation
lundgrenolof
requested review from
itdependsnetworks,
jmcgill298,
jvanderaa,
matt852 and
mjbear
as code owners
Author
|
Sorry about the commit mess. |
mjbear
reviewed
Mar 31, 2026
ntc_templates/templates/paloalto_panos_show_routing_route.textfsm
Outdated
Show resolved
Hide resolved
Use pattern repetition to consolidate the flags regex further. From the test data there can be up to three flag characters. The white space regex is made non-greedy so it does not capture a bunch of trailing white space.
The regex is a bit odd that it ends in a pipe symbol with no other characters on the other side of the pipe (boolean or). Change regex for: - metric - age - nexthop_if - next_as
Collaborator
|
After further review, I found the existing template regex that end in a pipe symbol to be peculiar. It predated this PR.
For example: I've updated the line patterns accordingly to the changes I made to those regex. Also it's possible to collapse most of the pattern lines into a single line with optional patterns. I was tempted to do that ... worked up that regex ... but have held off. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding ipv6 support in the show routing route parser