Add Mikrotik RouterOS interface wireless templates#2300
Add Mikrotik RouterOS interface wireless templates#2300k-ribot wants to merge 1 commit intonetworktocode:masterfrom
Conversation
k-ribot
requested review from
itdependsnetworks,
jmcgill298,
jvanderaa,
matt852 and
mjbear
as code owners
k-ribot
force-pushed
the
add-mikrotik-routeros-interface-wireless-templates
branch
4 times, most recently
from
543df8f to
15a7557
Compare
k-ribot
force-pushed
the
add-mikrotik-routeros-interface-wireless-templates
branch
from
15a7557 to
ee4cac1
Compare
|
I'll work through this, but it would be simpler to review with one template per PR. 😇 |
|
@k-ribot |
| Value ARP (\S+) | ||
| Value DISABLE_RUNNING_CHECK (\S+) | ||
| Value INTERFACE_TYPE (\S+) | ||
| Value MASTER_INTERFACE (\S*) |
There was a problem hiding this comment.
The test data always has an interface name listed for master-interface.
(Please adjust this since your forked repo doesn't allow maintainer changes. Thank you!)
| Value MASTER_INTERFACE (\S*) | |
| Value MASTER_INTERFACE (\S+) |
| Value SCAN_LIST (\S+) | ||
| Value WIRELESS_PROTOCOL (\S+) | ||
| Value RATE_SET (\S+) | ||
| Value SUPPORTED_RATES_B (\S*) |
There was a problem hiding this comment.
Every entry of supported-rates-b in the test data has rates listed.
Please provide test data to support this regex being zero or more non-white space characters.
| Value RATE_SET (\S+) | ||
| Value SUPPORTED_RATES_B (\S*) | ||
| Value SUPPORTED_RATES_A_G (\S+) | ||
| Value BASIC_RATES_B (\S*) |
There was a problem hiding this comment.
Each basic-rates-b instance in the provided test data has values listed.
Please provide supporting test data for the regex.
| Value VHT_SUPPORTED_MCS (\S*) | ||
| Value VHT_BASIC_MCS (\S*) |
There was a problem hiding this comment.
Test data shows entries for vht-supported-mcs and vht-basic-mcs that always have values.
To support the regex choice of \S*, please provide test data the the condition where the values aren't present.
2 participants
Add Mikrotik RouterOS interface wireless templates