drivers/tripplite_usb.c, UPGRADING.adoc: remove old bespoke reconnection limit tracking [#3541]

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>

Author: jimklimov

UPGRADING.adoc

@@ -74,9 +74,10 @@ The new `-A filename` option defaults to trying to use a `nutauth.conf` file
   reading one ('none' as the legacy default). See the updated manual pages
   for more details. [issues #3329, #3411]
 
-- `powervar_cx_usb` driver used a built-in limit on reconnection
-  attempts after which it exited. This was revised to follow the new common
-  setting `reconnect_max_tries` which defaults to trying indefinitely. [#3541]
+- The `powervar_cx_usb`, `tripplite_usb` drivers used a built-in limit on
+  reconnection attempts after which they exited ('60' and '10' respectively).
+  This was revised to follow the new common setting `reconnect_max_tries`,
+  which defaults to trying indefinitely now. [#3541]
 
 Changes from 2.8.4 to 2.8.5
 ---------------------------

drivers/tripplite_usb.c

@@ -279,8 +279,6 @@ static int is_smart_protocol(void)
 #define MAX_RECV_TRIES 10
 #define RECV_WAIT_MSEC 1000	/*!< was 100 for OMNIVS; SMARTPRO units need longer */
 
-#define MAX_RECONNECT_TRIES 10
-
 #define DEFAULT_OFFDELAY   64  /*!< seconds (max 0xFF) */
 #define DEFAULT_STARTDELAY 60  /*!< seconds (max 0xFFFFFF) */
 #define DEFAULT_BOOTDELAY  64  /*!< seconds (max 0xFF) */
@@ -677,8 +675,6 @@ void upsdrv_initinfo(void);
  */
 static void usb_comm_fail(int res, const char *msg)
 {
-	static int try_num = 0;
-
 	switch(res) {
 		case LIBUSB_ERROR_BUSY:
 			upslogx(LOG_WARNING,
@@ -689,26 +685,18 @@ static void usb_comm_fail(int res, const char *msg)
 #endif
 
 		default:
-			reconnect_trying(RECONNECT_TRYING);
-			/* FIXME [#3541]: Clean up driver custom tracking and MAX tolerance */
 			upslogx(LOG_WARNING,
 				"%s: Device detached? (error %d: %s)",
 				msg, res, nut_usb_strerror(res));
 
-			upslogx(LOG_NOTICE, "Reconnect attempt #%d", ++try_num);
 			hd = NULL;
 			reconnect_ups();
 
 			if(hd) {
 				upslogx(LOG_NOTICE, "Successfully reconnected");
-				try_num = 0;
 				reconnect_trying(RECONNECT_UPDATEINFO);
 				upsdrv_initinfo();
 				reconnect_trying(RECONNECT_SUCCESS);
-			} else {
-				if(try_num > MAX_RECONNECT_TRIES) {
-					fatalx(EXIT_FAILURE, "Too many unsuccessful reconnection attempts");
-				}
 			}
 			break;
 	}