upsmon, upssched: handle NOTIFYCMD and CMDSCRIPT values strictly as paths#3499
Open
jimklimov wants to merge 1 commit into
Open
upsmon, upssched: handle NOTIFYCMD and CMDSCRIPT values strictly as paths#3499jimklimov wants to merge 1 commit into
upsmon, upssched: handle NOTIFYCMD and CMDSCRIPT values strictly as paths#3499jimklimov wants to merge 1 commit into
Conversation
jimklimov
added
upsmon
Shutdowns and overrides and battery level triggers
|
A ZIP file with standard source tarball and another tarball with pre-built docs for commit ecf98e7 is temporarily available: NUT-tarballs-PR-3499.zip. |
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Jun 22, 2026
…CRIPT values strictly as paths [networkupstools#3499] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
|
❌ Build nut 2.8.5.4856-master failed (commit c5afe1a9f4 by @jimklimov) |
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Jun 22, 2026
…CRIPT values strictly as paths [networkupstools#3499] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
|
✅ Build nut 2.8.5.4858-master completed (commit 56e169d096 by @jimklimov)
|
|
✅ Build nut 2.8.5.4858-master completed (commit 56e169d096 by @jimklimov) |
…CRIPT values strictly as paths [networkupstools#3499] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
|
✅ Build nut 2.8.5.4896-master completed (commit 9d71ba391a by @jimklimov)
|
|
✅ Build nut 2.8.5.4898-master completed (commit 771863a5c8 by @jimklimov)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation was vague about this, and implementation used
system()which modern guidelines frown upon. Fix this to mean a single token with an exact path name (or a program inPATH) without arguments, inline scriptlets, etc.NOTE:
SHUTDOWNCMDshould not be impacted by this change, and can still take arguments as is often does (e.g.shutdown -t now).