Introduce a reconnect_max_tries setting for NUT drivers - #3541
Open
jimklimov wants to merge 24 commits into
Open
Introduce a reconnect_max_tries setting for NUT drivers#3541jimklimov wants to merge 24 commits into
reconnect_max_tries setting for NUT drivers#3541jimklimov wants to merge 24 commits into
Conversation
jimklimov
added
enhancement
service/daemon start/stop
|
A ZIP file with standard source tarball and another tarball with pre-built docs for commit 9e94a53 is temporarily available: NUT-tarballs-PR-3541.zip. |
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Jul 23, 2026
….adoc: introduce `reconnect_max_tries` setting for NUT drivers [networkupstools#3541] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
marked this pull request as draft
July 23, 2026 20:03
|
✅ Build nut 2.8.5.4975-master completed (commit 45ab5bdb79 by @jimklimov)
|
|
✅ Build nut 2.8.5.4976-master completed (commit 8a56bf4a6c by @jimklimov)
|
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Jul 24, 2026
….adoc: introduce `reconnect_max_tries` setting for NUT drivers [networkupstools#3541] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
|
✅ Build nut 2.8.5.4979-master completed (commit 3f1ca8c5f3 by @jimklimov)
|
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Jul 24, 2026
….adoc: introduce `reconnect_max_tries` setting for NUT drivers [networkupstools#3541] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
|
❌ Build nut 2.8.5.4980-master failed (commit 3147d3b1a8 by @jimklimov) |
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Jul 24, 2026
….adoc: introduce `reconnect_max_tries` setting for NUT drivers [networkupstools#3541] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Jul 24, 2026
…s "reconnect.updateinfo" [networkupstools#3541] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Jul 24, 2026
…te_t as enum with symbolic names instead of magic numbers [networkupstools#3541] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Jul 24, 2026
…kupstools#3541] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Jul 24, 2026
… enum arg values for consistent reporting [networkupstools#3541] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
✅ Build nut 2.8.5.4981-master completed (commit 3f11131b0d by @jimklimov)
|
|
✅ Build nut 2.8.5.4981-master completed (commit 3f11131b0d by @jimklimov) |
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Jul 25, 2026
….adoc: introduce `reconnect_max_tries` setting for NUT drivers [networkupstools#3541] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Jul 25, 2026
…s "reconnect.updateinfo" [networkupstools#3541] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Jul 25, 2026
…te_t as enum with symbolic names instead of magic numbers [networkupstools#3541] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Jul 25, 2026
…kupstools#3541] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Jul 27, 2026
…nd may_log_reconnect_trying() [networkupstools#3541] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
….adoc: introduce `reconnect_max_tries` setting for NUT drivers [networkupstools#3541] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
… not old [networkupstools#1923] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…IT_SUCCESS symbolic values to log debug traces [networkupstools#2670, networkupstools#1923] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…_EXIT_* values instead of exit_flag=NUM [networkupstools#2670] Also compare symbolic not numeric values when deciding on exit code. Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…networkupstools#2670] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…s "reconnect.updateinfo" [networkupstools#3541] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…te_t as enum with symbolic names instead of magic numbers [networkupstools#3541] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…kupstools#3541] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
… enum arg values for consistent reporting [networkupstools#3541] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…s#3541] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…pstools#3541] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…etworkupstools#3541] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…tools#3541] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
….c [networkupstools#3541] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…tools#3541] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ction limit tracking [networkupstools#3541] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
networkupstools#3541] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ools#3541] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ion limit tracking [networkupstools#3541] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…e reconnect_report_freq to manage verbosity of on-going reconnect_trying() streak [networkupstools#3541] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…that retain custom logging of reconnection details for now [networkupstools#3541] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…etworkupstools#3541] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…nd may_log_reconnect_trying() [networkupstools#3541] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
|
❌ Build nut 2.8.5.4988-master failed (commit 141403f51e by @jimklimov) |
|
✅ Build nut 2.8.5.4990-master completed (commit ded935d53b by @jimklimov)
|
|
✅ Build nut 2.8.5.4993-master completed (commit e935c2b6e8 by @jimklimov)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exit the driver after the counter expires, so someone else can restart it from scratch. Optional, not default.
Might help with numerous reports of reconnection loops, especially if taking advantage of systemd units with a drop-in
usb_resettercall, such as recent #3531 and a couple dozen before it over the years.NOTE: As of initial posting, some drivers may still have their own mechanisms to limit the amount of retries, and to report the reconnection attempts and results (and throttle such reporting). It is possible that while this PR brings consistency to the related code base in general, it would cause confusing messages in some drivers reporting similar things twice, etc. Some apparent locations were marked with TODO in the code, others might be discovered later. Cleaning that up is not necessarily a focus of this PR, but might be if it proves easy.