This repository was archived by the owner on Sep 22, 2024. It is now read-only.
support minimal mdx cases and add test fixture#159
Draft
deer wants to merge 1 commit into
Draft
Conversation
miguelrk
reviewed
Mar 8, 2024
| > => { | ||
| const mdxFiles = await scanForMDXFiles("routes"); | ||
| const routes: PluginRoute[] = await mdxPathsToRoutes(mdxFiles); | ||
| export async function mdx(config: MdxConfig): Promise<Plugin<NetzoState>> { |
Contributor
There was a problem hiding this comment.
Minor nit here, maybe keep arrow syntax here for consistency with the other plugins.
export const mdx = async (config: MdxConfig): Promise<Plugin<NetzoState>> => {}
miguelrk
reviewed
Mar 8, 2024
| // deno-lint-ignore ban-types | ||
| export type MdxConfig = {}; | ||
| export type MdxConfig = { | ||
| configLocation: string; |
Contributor
There was a problem hiding this comment.
We should look into using the same property across plugins. The unocss plugin uses url for this same value which should also be set to import.meta.url).
I have no preference really, but I think URL is more indicative than location (matches the url in import.meta.url). Maybe configURL would be best of both worlds? And we could change this also for the unocss plugin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small amount of life happened which prevented me from making any meaningful progress on this , but I finally got some space to at least get this up as a draft review. I hope to get back to it soon in order to add the much needed tests and document what's necessary to move it forward.