Allow token authorization instead of basic (requires WHM access)#1
Open
tturnerdev wants to merge 3 commits into
Open
Allow token authorization instead of basic (requires WHM access)#1tturnerdev wants to merge 3 commits into
tturnerdev wants to merge 3 commits into
Conversation
77f9dc8 to
50328d9
Compare
50328d9 to
d95eb26
Compare
Owner
|
I think there's a problem here: elseif (!$GLOBALS['token'] && !$response->status ) {
$msg = json_encode($response);
err("The CURL call returned valid JSON, but reported errors: $msg");
} elseif ( !$response->result->status ) {
$msg = json_encode($response);
err("The CURL call returned valid JSON, but reported errors: $msg");
}when response is good, and the token method is not used, A solution may be this: elseif (!$GLOBALS['token']){
if(!$response->status ) {
$msg = json_encode($response);
err("The CURL call returned valid JSON, but reported errors: $msg");
}
} elseif ( !$response->result->status ) {
$msg = json_encode($response);
err("The CURL call returned valid JSON, but reported errors: $msg");
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Authenticate and call
install_sslvia WHM API instead of cPanel UAPI.Requires WHM access, common for reseller accounts (not shared hosting)
Using a token is safer than basic authentication, allows access control, and revoke.
Ref: https://documentation.cpanel.net/display/SDK/Use+WHM+API+to+Call+cPanel+API+and+UAPI