Adding version dropdown to sphinx website Issue:#372#486
Adding version dropdown to sphinx website Issue:#372#486Transyltooniaa wants to merge 6 commits into
Conversation
|
I have implemented an automated GitHub Actions workflow for building and deploying Sphinx documentation with versioning. This ensures that each tagged release is correctly deployed, updates switcher.json dynamically, and maintains the latest version. I tested this on my fork of the repository, and the workflow executed successfully, handling versioning as expected. Request you to please let me know what you want to verify in this. |
JoeZiminski
left a comment
There was a problem hiding this comment.
Hi @Transyltooniaa thanks for this! It looks good, I need to double check with colleagues but I think the way to test this works is to merge it and see if we need to make any changes. Will double check! In the meantime please see some minor comments, cheers!
|
Thanks, @JoeZiminski, for the code review. Apologies for the late response. I will incorporate the above suggestions in the next 2 days. |
|
Hey @JoeZiminski . I have made the changes as suggested after the code review. Please have a look at it and let me know if anything seems missing / inappropriate. Cheers ! 😅 |
|
Thanks @Transyltooniaa! This looks great, testing this will be a bit tricky I need to confer with a colleague the best approach, as this might require merging to main to check it works. So the actual merging may be a slow process as it makes sense to merge some other PRs first. Don't worry with respect to GSoC, the contribution is very useful so the date of merge does not matter. I will keep you updated anyways, thanks again! |
|
Hi @Transyltooniaa thanks a lot for this, I will re-review but it looks good to me and I think any issues will only be apparent after testing in practice. I think this is as far as you can go with this without access to our CI system. I'll test this and merge ASAP, thanks! |
|
Thank you so much ! |
|
Hi @Transyltooniaa thanks again for this PR, in the end this logic was packaged into a central action that we will use instead to reduce code duplication. Thanks nonetheless for this contribution, it was useful to see all code relevant to the dropdown laid out like this. |
Title: Automate Sphinx Documentation Deployment with Versioned Switcher
Description
What is this PR?
Why is this PR needed?
addresses : #372
This PR enhances the Sphinx documentation deployment workflow for the forked
datashuttlerepository. It ensures that versioned documentation is deployed automatically whenever a new tag is pushed, and development builds (devversion) are properly handled. The new automation eliminates the need for manually updatingswitcher.jsonand thelatestdirectory.What does this PR do?
switcher.jsonto include the latest version while maintaining previous versions.latestdirectory always points to the newest stable release.References
This PR is related to automating documentation deployment similar to the main repository:
https://github.com/neuroinformatics-unit/datashuttle.githttps://github.com/Transyltooniaa/datashuttle.gitHow has this PR been tested?
latestdirectory correctly updates only when a non-development version is released.Is this a breaking change?
No, this PR does not break any existing functionality. It only improves the automation of documentation deployment.
Does this PR require an update to the documentation?
No major changes to documentation are required, as this PR only affects the deployment process. However, contributors should be aware that manual updates to
switcher.jsonand thelatestdirectory are no longer needed.Checklist: