Split conda test out into separate workflow#522
Merged
Conversation
7 tasks
niksirbi
approved these changes
Jun 16, 2025
Member
niksirbi
left a comment
niksirbi
left a comment
There was a problem hiding this comment.
Looks good @JoeZiminski. I've added a few optional comments.
Member
Author
|
Thanks @niksirbi! |
JoeZiminski
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further to #393 the workflows were changed to install through
condaand only install datashuttle from the repository. This was becausecondais the recommended install method so it made sense to test all dependencies were playing nice together when installed throughconda.In practice, this doesn't work because if a dependency is changed in a PR, it's not updated in the tests because the tests are pulling the old dependencies from
conda. So, this PR reverts this behavior and installs from source for testing. Second to this, a new workflow is added that does a basic check for the conda install (just install and--datashuttle help) to once weekly on a cron job. This should be sufficient to flag any dependency issues. It is not necessary to run all tests, as the full test suite is run on the conda-side when a new version is released on conda.No tests or docs are required.