Handle bad project names#527
Merged
Merged
Conversation
cs7-shrey
reviewed
Jun 22, 2025
cs7-shrey
left a comment
cs7-shrey
left a comment
Collaborator
There was a problem hiding this comment.
Looks good @JoeZiminski. I've added some minor comments.
JoeZiminski
force-pushed
the
handle_bad_project_names
branch
from
41d928e to
433c1e8
Compare
JoeZiminski
force-pushed
the
handle_bad_project_names
branch
from
ceeffdb to
2be3f0a
Compare
cs7-shrey
approved these changes
Jun 23, 2025
cs7-shrey
left a comment
cs7-shrey
left a comment
Collaborator
There was a problem hiding this comment.
Perfect. Looks good to me.
Member
Author
|
Thanks @cs7-shrey ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR handles two types of project names that were causing problems:
This raises an error if the project name is empty, and for the TUI adds a prefix to the id created from the project name to ensure numbers don't crash (as ids cannot start with a number).
Tests are added for these cases, no documentation is required.