Revert: Google drive connection method to config token based approach#553
Conversation
|
|
||
| # TODO: make this more robust | ||
| # extracting rclone's message from the json | ||
| output_json = json.loads(output.stdout) |
There was a problem hiding this comment.
Could this be added to a TODO on the main PR or feel free to make an issue if its a longer-term problem that is outside the scope of PRs (typically, TODOs in the code itself end up being forgotten about)
There was a problem hiding this comment.
Actually, we discussed about this TODO in the first version of the original PR when the rclone commands I used were relatively new. I copied some of the code from that commit so this TODO was also copied over. Back then, we agreed that most probably this should work as expected and that we can check how robust it is while testing. So, do you suggest I should remove it or just keep it as a reminder?
There was a problem hiding this comment.
Okay great @cs7-shrey, I think this could be a reminder on a PR (e.g. you can maintain a TODO list on the PR itself if useful) for us to test, and we can delete from the code. Feel free to merge after, thanks!
|
Hey @cs7-shrey cheers for this it all looks good to me, there were a couple of cases where the new option to have I left one comment on the |
* Add get_rclone_config_name_local and rename get_rclone_config_name to get_rclone_config_name_central. * Add new transfer function. * Fix rename in tests. * Tidy up the search functions. * Fix circular import. * Adding more tests and fixing an edge case. * Add wildcards to local filesystem transfer tests. * Added tests to ssh. * Remove unused function. * Move teardown to fix tests on macos. * Revert get_rclone_config_name_central name change. * Add documentation to tests. * Remove unecessary sorted. * Fix cyclical import. * Remove unecessary wildcard. * Remove unused functions.
cs7-shrey
force-pushed
the
revert_gdrive_connection_method
branch
from
cb30ecf to
bef1d3d
Compare
cs7-shrey
merged commit 5899eca
into
neuroinformatics-unit:add_gdrive_aws_remote
2 participants
Description
What is this PR
Why is this PR needed?
Reverting back to config token based approach for google drive connections as google cloud had some policy changes
What does this PR do?
Include back the config token method of setting up google drive connections in absence of a browser.
References
Please reference any existing issues/PRs that relate to this PR.
How has this PR been tested?
Tested locally
Is this a breaking change?
No
Does this PR require an update to the documentation?
No
Checklist: