Keep default drive for SelectDirectoryTreeScreen as home.#557
Merged
Conversation
cs7-shrey
approved these changes
Aug 1, 2025
Collaborator
|
Hey @JoeZiminski, you mistakenly mentioned #505, in the PR body. Can you change it to #550 ? |
Member
Author
|
thanks @cs7-shrey! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #550 by ensuring that the default path on the DirectoryTree in the select path window (used for new project and validate screen) is the home path. The problem is that the drive select (e.g. select C:, D:) was automatically triggered (I think when it is composed) calling
on_select_changedwhich reset the directory tree to the drive.I couldn't find a way around this except to use a flag, which isn't ideal but it works. Now the default home path is used and only reset to the drive base when the select is changed. Also, I removed the
path_argument forSelectDirectoryTreebecause it was never used.Docs do not need changing and a test is updated.