Fix rclone message on tests.#565
Merged
Merged
Conversation
Member
Author
|
Hey @alessandrofelder just tagging again post-OSW although I know you are still super busy 😂 but hopefully this is a quick one |
alessandrofelder
approved these changes
Aug 21, 2025
Member
alessandrofelder
left a comment
alessandrofelder
left a comment
There was a problem hiding this comment.
Great, I am happy with this. thanks @JoeZiminski (and sorry for letting this drop off my radar!)
Member
Author
|
thanks @alessandrofelder! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #538, there is a newline in the error message that says rclone is not installed, meaning it does not display properly in test output:
This PR fixes this by removing the newline in the test environment. I kept the newline for the usual environment because I thought it looked easier to read:
what do you think @alessandrofelder? If its not any easier to read, we can just remove the newline entirely and avoid some complexity.