Skip to content

ADD: Tests for Google Drive and AWS Connection Methods#567

Merged
cs7-shrey merged 3 commits into
neuroinformatics-unit:gdrive_aws_testsfrom
cs7-shrey:gdrive_aws_tests
Aug 5, 2025
Merged

ADD: Tests for Google Drive and AWS Connection Methods#567
cs7-shrey merged 3 commits into
neuroinformatics-unit:gdrive_aws_testsfrom
cs7-shrey:gdrive_aws_tests

Conversation

@cs7-shrey
Copy link
Copy Markdown
Collaborator

Description

This PR adds tests for Google Drive and AWS connection methods including tests for transfers, TUI and unit tests for certain functions.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@cs7-shrey cs7-shrey marked this pull request as draft August 2, 2025 17:16
@cs7-shrey
Copy link
Copy Markdown
Collaborator Author

cs7-shrey commented Aug 2, 2025

Hey @JoeZiminski, I have written the tests to test google drive and aws transfers via the datashuttle python api. These are quite similar to the one in the SSH. If this approach looks good, can you please add the credentials to the github secrets and then we can run the tests in the CI.
We'd need the following variables in the github secrets

GDRIVE_CLIENT_ID
GDRIVE_CLIENT_SECRET
GDRIVE_ROOT_FOLDER_ID
GDRIVE_CONFIG_TOKEN

AWS_ACCESS_KEY_ID
AWS_REGION
AWS_BUCKET_NAME
AWS_SECRET_ACCESS_KEY

Also, the tests for Google drive are extremely slow. On my pc, it took about 20 minutes to run. What do you think can be done about this?

@JoeZiminski
Copy link
Copy Markdown
Member

Hey @cs7-shrey cheers for this! I added the secrets, I tested locally with gdrive (will also check aws) by simply adding to os.environ at the top of the test script and it worked (with some formatting adjustments) but not sure if this will translate to the CI.

I think because this is on your fork you cannot see the main repo's secrets. If you can branch off the NIU main to create gdrive_aws_tests then merge this branch into that, it will hopefully work 🤞

@cs7-shrey cs7-shrey changed the base branch from add_gdrive_aws_remote to gdrive_aws_tests August 5, 2025 05:42
@cs7-shrey cs7-shrey marked this pull request as ready for review August 5, 2025 05:43
@cs7-shrey cs7-shrey merged commit 5df1ea0 into neuroinformatics-unit:gdrive_aws_tests Aug 5, 2025
5 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants