Partially revert lsjson#571
Merged
Merged
Conversation
JoeZiminski
force-pushed
the
partially_revert_lsjson
branch
from
9a39f9f to
d7472a9
Compare
cs7-shrey
reviewed
Aug 22, 2025
Collaborator
cs7-shrey
left a comment
cs7-shrey
left a comment
There was a problem hiding this comment.
Looks good @JoeZiminski. Just a few minor suggestions.
cs7-shrey
approved these changes
Aug 26, 2025
Member
Author
|
thanks @cs7-shrey ! |
This was referenced Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR partially reverts #551 by using local filesystem searches when possible for speed improvement (avoiding process creation which is slow on Windows).
It essentially creates a duplicate function,
search_local_filesystemthat should have the same output assearch_central_via_connectionbut does not callrclone. This is faster as a new process does not need to be made withsubprocess.run(). This slowness is particularly noticeable during live-validation on the create-folders screen, it is so bad that is makes the user experience very poor. On Linux, it is less of an issue.This solution is not at all ideal, we now have two functions doing the same thing. When all searches were done through
search_central_via_connection, it meant that all local filesystem tests implicitly tested the behaviour ssh, aws, google drive tests. There are many more local filesystem transfer tests because these are much quicker to run. Therefore, this duplication is reducing test coverage. The solution is just to add a few more explicit tests to ssh, aws and google drive #577 and in this PR, perform a set of tests to check that the outputs of these functions are the same under many conditions.I thought another potential solution in #551 is to create a process on
datashuttlewith POpen and hold it for the lifetime of the class, and call it when needed. However, as far as I can tell this is not how POpen works. It will also be a high burden and possible source of bugs to manage the lifetime of the process on the datashuttle class. So I think this is a better solution, although not ideal.