Add exit button#573
Merged
Merged
Conversation
Member
IgorTatarnikov
left a comment
There was a problem hiding this comment.
Looks great! Is it worth adding a warning when Esc is hit? I worry about incidental key pushes leading to an unexpected exit.
| ``datashuttle`` with our [Getting Started Tutorial](getting-started-walkthrough). | ||
|
|
||
| To quit ``datashuttle`` in the terminal, press `CTRL+C`. | ||
| To quit ``datashuttle`` in the terminal, press `CTRL+Q`. |
Member
Author
|
Good point, do you think CTRL+ESC would be weird? Otherwise a warning pop-up window is definitely dooable, I think I am just being lazy 😅 |
Member
|
Ctrl+ESC would work but a pop-up might be nice for the future! Maybe change to Ctrl + Esc for now and open an issue to make a pop-up in the future. |
IgorTatarnikov
approved these changes
Aug 7, 2025
Member
Author
|
Hey @IgorTatarnikov in the end I added the warning window, it was pretty quick! If you could take a quick look whenever you have time that would be great. Cheers! |
IgorTatarnikov
approved these changes
Aug 20, 2025
Member
IgorTatarnikov
left a comment
There was a problem hiding this comment.
Works great! The confirmation popup is a great addition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #545 by adding an 'Exit' button to the main window. I tried to use
CTRL+Cfor copy directly, but forgot that in some cases this still quits the application on Windows. I think under certain conditions thetextualevent loop is in a strange / awaiting state and the CTRL+C is not caught, defaulting to windows behavior which is to exit the application (also encountered in #458).As such,
CTRL+Qis maintained for copy. However now,CTRL+Cdoes not exit the application, but causes a popup with the following information:This is because I think it might be annoying if you were trying to copy for the application to exit. It also lets the user know about a cool trick that if you select while holding shift, you can copy any text (found by @cs7-shrey).