Skip AWS and GDRIVE tests when environment variables not set.#589
Conversation
cs7-shrey
left a comment
There was a problem hiding this comment.
Hey @JoeZiminski, we have similar tests in tests_tui as well for gdrive and aws connection setup. So, I was wondering if we can move the has_variables... function logic to test_utils.py and then skip those TUI tests as well.
|
Thanks @cs7-shrey I forgot about those! I did a small refactor to include these in the transfer tests. Even though it's a bit strange to have TUI tests outside of |
cs7-shrey
left a comment
There was a problem hiding this comment.
LGTM. I think we can remove the directoriestests_tui/aws and tests_tui/gdrive.
|
Thanks Shrey, locally I have them deleted but I can see one is still there on the github repo 🤔 sometimes git doesn't handle empty folders properly, I'll merge and hope it disappears. Thanks! Also just a general note on this PR, the SonarCloud is failing for a code-duplication reason that is actually acceptable and wanted, so not addressing. |
Currently AWS or GDrive tests fail when run locally if environment variables required for set up are not set. Now, these tests are just skipped.