Skip to content

Rename setup_google_drive_connection -> setup_gdrive_connection.#590

Merged
JoeZiminski merged 2 commits into
mainfrom
rename_setup_google_drive_connection
Sep 8, 2025
Merged

Rename setup_google_drive_connection -> setup_gdrive_connection.#590
JoeZiminski merged 2 commits into
mainfrom
rename_setup_google_drive_connection

Conversation

@JoeZiminski

Copy link
Copy Markdown
Member

This PR renames setup_google_drive_connection to setup_gdrive_connection. The reason is that for all other API arguments it is refered to as gdrive rather than google drive, so this is gone for consistency. Alternatively, gdrive references could be changed to google_drive, but some of these arguments are already quite long. I think it gdrive is a pretty intuitive and easy-to-remember abbreviation. What do you think about this @cs7-shrey ?

@cs7-shrey

Copy link
Copy Markdown
Collaborator

It's a nice thought. I think we can rename other such variables too in interface.py. Like, google_drive_rclone_setup_process, terminate_google_drive_setup, etc.

@JoeZiminski

Copy link
Copy Markdown
Member Author

Thanks @cs7-shrey good shout! Have updated

@JoeZiminski JoeZiminski merged commit b4851cb into main Sep 8, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants