Rename setup_google_drive_connection -> setup_gdrive_connection.#590
Merged
Conversation
Collaborator
|
It's a nice thought. I think we can rename other such variables too in |
Member
Author
|
Thanks @cs7-shrey good shout! Have updated |
cs7-shrey
approved these changes
Sep 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames
setup_google_drive_connectiontosetup_gdrive_connection. The reason is that for all other API arguments it is refered to asgdriverather thangoogle drive, so this is gone for consistency. Alternatively,gdrivereferences could be changed togoogle_drive, but some of these arguments are already quite long. I think itgdriveis a pretty intuitive and easy-to-remember abbreviation. What do you think about this @cs7-shrey ?