Provide feedback on inheritance structure for datatype checkboxes#678
Closed
Copilot wants to merge 1 commit into
Closed
Provide feedback on inheritance structure for datatype checkboxes#678Copilot wants to merge 1 commit into
Copilot wants to merge 1 commit into
Conversation
Copilot
AI
changed the title
[WIP] Fix dynamically turning off transfer checkboxes
Provide feedback on inheritance structure for datatype checkboxes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Responded to maintainer request for architectural feedback on the refactored datatype checkbox inheritance structure.
Context
The PR refactored from a parameter-based design (
tab_nameas constructor arg) to an inheritance-based design (tab_nameas class attribute withBaseDatatypeCheckboxesbase class and subclasses).Feedback provided
TransferDatatypeCheckboxes.__init__is redundant (only callssuper()with same args) and can be removedNo code changes made—this was a review-only response to maintainer question.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.