Handle textual v8, unpin textual in pyproject.toml#691
Open
AdityaGupta716 wants to merge 3 commits into
Open
Conversation
5 tasks
Member
|
Thanks for this @AdityaGupta716! That looks like a good fix, will look into this after the next release |
JoeZiminski
approved these changes
Apr 10, 2026
Member
JoeZiminski
left a comment
JoeZiminski
left a comment
There was a problem hiding this comment.
Thanks @AdityaGupta716! This works great, I tested it also on v3.4.0 and it works well for old versions, so I kept the pin >=3.4.0 so any textual version can be used, just in case. But most users will default to the latest version. Cheers!
Contributor
Author
|
hii @JoeZiminski, thanks for the testing and confirmation,i looked into the failing test and it seems to be pre-existing , not related to this PR. The test asserts "size changed" in the error message, but the CI's rclone version now produces a different error string. The same issue exists in test_tui_transfer.py too. should i fix it in this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #688
Changes
Updated textual dependency in pyproject.toml from >=3.4.0,<8 to >=8.0.0, removing the temporary pin added in #689
Fixed InvalidSelectValueError in configs_content.py by replacing select.value = False with select.clear(), which is the correct API in textual v8
Before
Selecting an existing project crashed with
`InvalidSelectValueError:
After
Existing projects load correctly with textual v8.