Fix and document small-fix commits#694
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The below commits were pushed to main in error. They were performed when running manual checks in the run up to the next release. I may have bypassed the main branch protections then forgot 🤦
The commits are:
Don't throw rclone error for local only project.
This PR fixes some strange behaviour in which even if a local-only project was selected, an error that Rclone was required would appear. However, this was not accurate, everything functions normally without Rclone except one set up of the local file rclone config, which can be set up conditionally.
Fix BaseDatatypeCheckboxes tcss.
This PR fixes some strange formatting in which the data-type checkboxes for create folders were in one long column instead of grid format. This was due to a renamed class that was not updated in the tcss.
Disable search central for suggestions in Local Only mode.
The checkbox that allows the user to search for central suggestions was available in local only mode, which is confusing. This commit disables the widget in this case.
Fix logging (all vars) for 'update_config_file()'.
update_config_filedid not log the passed kwargs (only logging the update dict), this was added for completion.Fix show transfer status broken due to moved logs.
I think the log folder was moved, meaning logs were included in showing transfer status and meant that the top level folder was always highlighted as changed. This is fixed by filtering out the logs folder during rclone check.
Fix 'Go To Project' screen appearing when setting up connection on project tab.
The 'Go To Project' button that appears when a connection is set up was showing when the configs were accessed from within a project. This is now disabled in this case.
A small fix related to these commits is included in this PR.