Fix check status error#695
Merged
Merged
Conversation
JoeZiminski
force-pushed
the
fix_check_status_error
branch
from
1de8c60 to
7fbb823
Compare
JoeZiminski
force-pushed
the
fix_check_status_error
branch
from
7fbb823 to
71a471a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes error handling for the transfer status display functionality in the TUI. Previously, when get_local_and_central_file_differences was called directly and encountered an error (e.g., missing Rclone config file), it would crash the TUI. The fix wraps this call in the Interface class following the established error handling pattern, allowing errors to be gracefully displayed to the user via an error dialog.
Changes:
- Improved the error message for missing Rclone config files to be more user-friendly
- Refactored transfer status checking to use the Interface wrapper pattern for proper error handling
- Added a new
get_transfer_diffsmethod to the Interface class that wraps the file difference checking with try-except
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| datashuttle/utils/rclone.py | Improved error message clarity for missing Rclone config files |
| datashuttle/tui/tabs/transfer_status_tree.py | Refactored to call get_transfer_diffs through Interface with proper error handling instead of direct function call |
| datashuttle/tui/interface.py | Added new get_transfer_diffs wrapper method following the Interface pattern for consistent error handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The call to
get_local_and_central_file_differencesfor the TUI, which displays the transfer status of files (e.g. local-only, changed on local etc) was not wrapped in theInterfaceclass. As such, when an error occured, it was not properly handled by the TUI. This is now fixed.