Add tests for search_central_via_connection with search_path=None#707
Merged
Conversation
Co-authored-by: JoeZiminski <55797454+JoeZiminski@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on handling None case in search path fix
Add tests for Mar 17, 2026
search_central_via_connection with search_path=None
JoeZiminski
approved these changes
Mar 17, 2026
JoeZiminski
added a commit
that referenced
this pull request
Mar 17, 2026
* Fix search path `None` case. * Fix issues. * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Improve error diagnostics for `search_central_via_connection` when `search_path` is `None` (#708) * Initial plan * Move display_search_path into if block with rclone remote name for None case Co-authored-by: JoeZiminski <55797454+JoeZiminski@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JoeZiminski <55797454+JoeZiminski@users.noreply.github.com> * Add tests for `search_central_via_connection` with `search_path=None` (#707) * Initial plan * Add test for search_central_via_connection with search_path=None Co-authored-by: JoeZiminski <55797454+JoeZiminski@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JoeZiminski <55797454+JoeZiminski@users.noreply.github.com> * Revert AI nonsense. * Small tidy up. --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
search_path=Nonecode path insearch_central_via_connection(used whencfg["central_path"]isNonefor Google Drive) had no test coverage, risking silent regressions.Changes
test_search_central_none_search_pathintests/tests_integration/test_search_methods.py:call_rclone_for_central_connectionto return a fake directory listingsearch_path=Nonedoesn't raisereturn_full_path=TruereturnsPathobjects (e.g.Path("sub-001")) rather than bare stringsreturn_full_path=Falsereturns plain strings📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.