Warn when overwriting existing loader in register_loader#908
Open
swagat-mishra28 wants to merge 1 commit into
Open
Warn when overwriting existing loader in register_loader#908swagat-mishra28 wants to merge 1 commit into
swagat-mishra28 wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Closes #903
Summary
While reviewing the loader registration mechanism in
movement/io/load.py, I noticed thatregister_loader()silently overwrites existing entries in the_LOADER_REGISTRYwhen a loader is registered multiple times for the same
source_software.This behaviour can make debugging difficult, as an existing loader may be replaced
without any indication.
This PR improves transparency by emitting a warning when a loader is being
overwritten, while preserving the current behaviour that allows overwriting.
Changes
register_loader()when a loader for the samesource_softwarealready exists in_LOADER_REGISTRY.Example:
Testing
All tests were executed after the change:
Result:
Please let me know if you would prefer raising an error instead of a warning for duplicate loader registrations.