Skip to content

Warn when overwriting existing loader in register_loader #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
swagat-mishra28 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Warn when overwriting existing loader in register_loader #908

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions movement/io/load.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,7 @@ def register_loader(
def decorator(
loader_fn: Callable[Concatenate[TInputFile, P], xr.Dataset],
) -> Callable[Concatenate[TInputFile, P], xr.Dataset]:

@wraps(loader_fn)
def wrapper(file: TInputFile, *args, **kwargs) -> xr.Dataset:
if not validators_list:
Expand All @@ -222,8 +223,15 @@ def wrapper(file: TInputFile, *args, **kwargs) -> xr.Dataset:
)
return loader_fn(valid_file, *args, **kwargs) # type: ignore[arg-type]

# Warn if loader already exists
if source_software in _LOADER_REGISTRY:
logger.warning(
f"Loader for '{source_software}' is being overwritten."
)

# Register the loader in the global registry
_LOADER_REGISTRY[source_software] = cast("LoaderProtocol", wrapper)

return wrapper

return decorator
Expand Down