Allow individual-wise confidence arrays#989
Open
ishan372or wants to merge 1 commit into
Open
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #989 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 41 41
Lines 2824 2829 +5
=========================================
+ Hits 2824 2829 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
Currently,
confidence_arrayvalidation only supports keypoint-level confidence arrays with shape(time, keypoint, individual). However, some pose estimation formats such as COCO may provide confidence values at the individual level instead, with shape(time, individual).This PR is needed to support these valid confidence formats without breaking existing behavior.
What does this PR do?
This PR extends
confidence_arrayvalidation to support both keypoint-level confidence arrays with shape(time, keypoint, individual)andindividual-level confidence arrayswith shape(time, individual). Existing validation behavior for invalid shapes is preserved, and_validate_array_shaperemains unchanged. In addition, tests were added to cover validkeypoint-level confidence arrays,valid individual-level confidence arrays, andinvalid confidence array shapes.References
Related to COCO-format compatibility discussions.
How has this PR been tested?
The changes were tested locally by instantiating
ValidPosesInputswith valid keypoint-level confidence arrays, valid individual-level confidence arrays, and invalid confidence array shapes to verify the expected validation behavior. Validator tests were also run locally using pytest, and existing validation behavior was confirmed to remain unchanged.Is this a breaking change?
No.
Existing
keypoint-level confidence arrayscontinue to behave as before. This PR only adds support for an additional valid confidence array shape.Does this PR require an update to the documentation?
Documentation updates are required since this PR extends the accepted
confidence_arrayvalidation behavior by adding support for individual-level confidence arrays with shape(time, individual). So documentation has to reflect the new available shape ofconfidence_array.Checklist: