Add tests for data encoding hooks#36
Merged
Merged
Conversation
Closed
Due to: `mamba: command not found`
To resolve: `CondaError: Run 'conda init' before 'conda activate'`
…ing `drop if_binary` encoding
SomeoneInParticular
changed the title
…ensure more robust testing.
SomeoneInParticular
approved these changes
Apr 15, 2025
Collaborator
SomeoneInParticular
left a comment
SomeoneInParticular
left a comment
There was a problem hiding this comment.
Going to ignore the ReadTheDocs error, as this branch hasn't implemented the documentation yet. Otherwise, this LGTM!
Member
Author
|
Thanks for the fix in ea7f32d Tests are passing: https://github.com/neuropoly/modular_optuna_ml/actions/runs/14479513281/job/40613212894?pr=36 --> merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
Resolves: #23