Skip to content

Rename RDP_INFO flags to spec names#3777

Merged
matt335672 merged 1 commit into
neutrinolabs:develfrom
gpotter2:rename-rdpflags
Apr 1, 2026
Merged

Rename RDP_INFO flags to spec names#3777
matt335672 merged 1 commit into
neutrinolabs:develfrom
gpotter2:rename-rdpflags

Conversation

@gpotter2
Copy link
Copy Markdown
Contributor

This is a part of #3776

Copy link
Copy Markdown
Member

@matt335672 matt335672 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all for doing this - I've done a few myself, but is there a reason why we're not using the actual spec names here (i.e. without the RDP_ prefix)?

The only reason I can think of not to use spec names is if it would cause a conflict in xrdp-neutrinordp.c. I've just run a quick compile check and this isn't the case.

I'm happy to be argued out of this position.

@gpotter2
Copy link
Copy Markdown
Contributor Author

I don't have an opinion. Do you want me to change it?

@matt335672
Copy link
Copy Markdown
Member

I think so. If we get a clash later we can fix it then. I think sticking as close to the spec as we can is a good thing to at least try to achieve.

@gpotter2
Copy link
Copy Markdown
Contributor Author

gpotter2 commented Mar 31, 2026

Fine by me, done ! In this case I also took the liberty to split the "normal". I think I kept the RDP_ initially because I couldn't figure how to rename the "normal"

Copy link
Copy Markdown
Member

@metalefty metalefty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@metalefty metalefty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops.

@matt335672 matt335672 merged commit 8e5875e into neutrinolabs:devel Apr 1, 2026
15 checks passed
@gpotter2
Copy link
Copy Markdown
Contributor Author

gpotter2 commented Apr 1, 2026

Thanks ! this PR only exists to make #3776 possible, feel free to take a look 😊

@gpotter2 gpotter2 deleted the rename-rdpflags branch April 2, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants