Rename RDP_INFO flags to spec names#3777
Conversation
matt335672
left a comment
There was a problem hiding this comment.
I'm all for doing this - I've done a few myself, but is there a reason why we're not using the actual spec names here (i.e. without the RDP_ prefix)?
The only reason I can think of not to use spec names is if it would cause a conflict in xrdp-neutrinordp.c. I've just run a quick compile check and this isn't the case.
I'm happy to be argued out of this position.
|
I don't have an opinion. Do you want me to change it? |
|
I think so. If we get a clash later we can fix it then. I think sticking as close to the spec as we can is a good thing to at least try to achieve. |
ce684a5 to
42b830f
Compare
|
Fine by me, done ! In this case I also took the liberty to split the "normal". I think I kept the |
|
Thanks ! this PR only exists to make #3776 possible, feel free to take a look 😊 |
This is a part of #3776