fix(ingest): enforce non-null nextState across sources

Author: neuwcodebox

src/modules/ingest/app/sources/airkorea-o3-warning.source.ts

@@ -52,16 +52,16 @@ export class AirkoreaO3WarningSource implements Source {
 
     const html = await response.text();
     const rows = parseWarningRows(html);
+    const previousState = parseState(state);
+    const seen = new Map<string, string>(Object.entries(previousState.seen));
     if (rows.length === 0) {
-      return { events: [], nextState: state };
+      return { events: [], nextState: buildState(seen) };
     }
 
     const now = new Date();
     const nowIso = now.toISOString();
     const nowMs = now.getTime();
     const groups = groupWarningRows(rows, nowMs);
-    const previousState = parseState(state);
-    const seen = new Map<string, string>(Object.entries(previousState.seen));
 
     const events: SourceEvent[] = [];
     for (const group of groups) {
@@ -233,11 +233,7 @@ const parseState = (state: string | null): O3WarningState => {
   }
 };
 
-const buildState = (seen: Map<string, string>): string | null => {
-  if (seen.size === 0) {
-    return null;
-  }
-
+const buildState = (seen: Map<string, string>): string => {
   const payload: Record<string, string> = {};
   for (const [key, value] of seen) {
     payload[key] = value;

src/modules/ingest/app/sources/airkorea-pm-warning.source.ts

@@ -89,13 +89,13 @@ export class AirkoreaPmWarningSource implements Source {
       page += 1;
     }
 
+    const previousState = parseState(state);
+    const seen = new Map<string, string>(Object.entries(previousState.seen));
     if (rows.length === 0) {
-      return { events: [], nextState: state };
+      return { events: [], nextState: buildState(seen) };
     }
 
     const groups = groupWarningRows(rows, nowMs);
-    const previousState = parseState(state);
-    const seen = new Map<string, string>(Object.entries(previousState.seen));
 
     const events: SourceEvent[] = [];
     for (const group of groups) {
@@ -285,11 +285,7 @@ const parseState = (state: string | null): PmWarningState => {
   }
 };
 
-const buildState = (seen: Map<string, string>): string | null => {
-  if (seen.size === 0) {
-    return null;
-  }
-
+const buildState = (seen: Map<string, string>): string => {
   const payload: Record<string, string> = {};
   for (const [key, value] of seen) {
     payload[key] = value;

src/modules/ingest/app/sources/disaster-sms.source.ts

@@ -492,9 +492,9 @@ const parseSerial = (value: string | null): number | null => {
   return Math.trunc(parsed);
 };
 
-const getNextSerialState = (items: DisasterSmsItem[], lastSeenSerial: number | null): string | null => {
+const getNextSerialState = (items: DisasterSmsItem[], lastSeenSerial: number | null): string => {
   if (items.length === 0) {
-    return lastSeenSerial === null ? null : String(lastSeenSerial);
+    return lastSeenSerial === null ? '' : String(lastSeenSerial);
   }
 
   const maxSerial = Math.max(...items.map((item) => item.MD101_SN));

src/modules/ingest/app/sources/flood-alert.source.ts

@@ -338,10 +338,6 @@ function parseState(state: string | null): FloodAlertState {
   }
 }
 
-function buildState(seen: Map<string, string>): string | null {
-  if (seen.size === 0) {
-    return null;
-  }
-
+function buildState(seen: Map<string, string>): string {
   return JSON.stringify({ seen: Object.fromEntries(seen) });
 }

src/modules/ingest/app/sources/kasa-space-weather-crisis-alert.source.ts

@@ -227,11 +227,7 @@ function parseState(state: string | null): SpaceWeatherCrisisState {
   }
 }
 
-function buildState(seen: Map<string, string>): string | null {
-  if (seen.size === 0) {
-    return null;
-  }
-
+function buildState(seen: Map<string, string>): string {
   const payload: Record<string, string> = {};
   for (const [key, value] of seen) {
     payload[key] = value;

src/modules/ingest/app/sources/kdca-press-release.source.ts

@@ -272,11 +272,7 @@ function parseState(state: string | null): KdcaPressState {
   }
 }
 
-function buildState(seen: Map<string, string>): string | null {
-  if (seen.size === 0) {
-    return null;
-  }
-
+function buildState(seen: Map<string, string>): string {
   const payload: Record<string, string> = {};
   for (const [key, value] of seen) {
     payload[key] = value;

src/modules/ingest/app/sources/kma-aws-observation.source.ts

@@ -960,7 +960,7 @@ function parseState(state: string | null): AwsState {
   }
 }
 
-function buildState(stateMap: Map<string, AwsStateEntry>): string | null {
+function buildState(stateMap: Map<string, AwsStateEntry>): string {
   return JSON.stringify({ entries: Object.fromEntries(stateMap) });
 }
 

src/modules/ingest/app/sources/kma-overseas-earthquake.source.ts

@@ -471,6 +471,6 @@ function parseState(state: string | null): OverseasEarthquakeState {
   }
 }
 
-function buildState(seen: Map<string, string>): string | null {
+function buildState(seen: Map<string, string>): string {
   return JSON.stringify({ seen: Object.fromEntries(seen) });
 }

src/modules/ingest/app/sources/kma-pews-earthquake.source.ts

@@ -75,7 +75,7 @@ export class KmaPewsEarthquakeSource implements Source {
       const simulatedTimeMs = Date.now() - this.timeOffsetMs;
       if (simulatedTimeMs >= this.simEndUtcMs) {
         this.stopSimulation();
-        return { events: [], nextState: state };
+        return { events: [], nextState: buildState(parsedState) };
       }
     }
 
@@ -107,7 +107,7 @@ export class KmaPewsEarthquakeSource implements Source {
 
     const phase = parsePhase(bytes, this.headerLengthBytes);
     if (phase < 2) {
-      return { events: [], nextState: state };
+      return { events: [], nextState: buildState(parsedState) };
     }
 
     const info = parseEarthquakeInfo(bytes);
@@ -119,7 +119,7 @@ export class KmaPewsEarthquakeSource implements Source {
     const previousAlarmId = buildAlarmId(parsedState.lastEqkId, parsedState.lastPhase);
     const currentAlarmId = buildAlarmId(info.eqkId, phase);
     if (currentAlarmId && previousAlarmId === currentAlarmId) {
-      return { events: [], nextState: state };
+      return { events: [], nextState: buildState(parsedState) };
     }
 
     const event = buildEarthquakeEvent(phase, info, parsedState.lastEqkId, parsedState.lastPhase, binTimeStr);
@@ -232,11 +232,7 @@ const parseState = (state: string | null): PewsState => {
   }
 };
 
-const buildState = (state: PewsState): string | null => {
-  if (!state.lastEqkId && state.lastPhase === null) {
-    return null;
-  }
-
+const buildState = (state: PewsState): string => {
   return JSON.stringify(state);
 };
 

src/modules/ingest/app/sources/kma-weather-warning.source.ts

@@ -358,11 +358,7 @@ const parseState = (state: string | null): WarningState => {
   }
 };
 
-const buildState = (seen: Map<string, string>): string | null => {
-  if (seen.size === 0) {
-    return null;
-  }
-
+const buildState = (seen: Map<string, string>): string => {
   return JSON.stringify({ seen: Object.fromEntries(seen) });
 };