Bump wp-module-installer dependency to ^1.7.4#932
Merged
Conversation
The auto-install of Payments & Shipping (detect_plugin_activation ->
PluginInstaller::install('nfd_slug_wp_plugin_payments_shipping')) relies
on the catalog entry that ships in wp-module-installer 1.7.4. The previous
^1.7.3 constraint allowed the older 1.7.3 release, which predates that
entry, so composer could resolve an installer without the slug and the
install call would silently no-op.
Bump the constraint to ^1.7.4 and refresh composer.lock accordingly.
Contributor
AI code review✅ Strengths
|
Contributor
|
Coverage: Base 8.88% → PR 8.88% (must not decrease). |
vikasrana1998
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://newfold.atlassian.net/browse/PRESS0-3627
Proposed changes
The auto-install of Payments & Shipping added in #930 (
detect_plugin_activation()→PluginInstaller::install('nfd_slug_wp_plugin_payments_shipping', true)) depends on the catalog entry that ships in wp-module-installer 1.7.4 (added in newfold-labs/wp-module-installer#331, released in tag1.7.4).The current constraint
^1.7.3also permits the older1.7.3release (tagged 2026-03-23, before #331), which does not contain thenfd_slug_wp_plugin_payments_shippingslug. With^1.7.3, composer could resolve an installer without that entry — in which case the install call falls through to aWP_Errorand silently no-ops (no fatal, but the plugin is never installed). The committedcomposer.lockwas in fact pinned to the old 1.7.3 (ref6c0471fc).requireconstraint:newfold-labs/wp-module-installer^1.7.3→^1.7.4.composer.lock(installer1.7.3→1.7.4, ref3d3b9004) viacomposer update newfold-labs/wp-module-installer.composer validatepasses.Type of Change
Further comments
Dependency/lock change only. Guarantees the Payments & Shipping catalog entry is present wherever this module is consumed (e.g. the Bluehost plugin), so the WooCommerce-activation auto-install works as intended.