PopupList linked to the wrong option

[jruo]

If there are two PopupList options that share the same label and the same enum member names (or simply just the same enum type), the second option will be incorrectly linked to the first one.

The first option controls itself, and the second option also controls the first option. The second option cannot be changed.

public class Settings : UnityModManager.ModSettings, IDrawable
{
    public enum FirstEnum
    {
        A,
        B,
        C
    }

    public enum SecondEnum
    {
        A,
        B,
        C
    }

    [Header("Options for a thing")]
    [Draw("Selection", DrawType.PopupList)]
    public FirstEnum FirstSelection = FirstEnum.A;

    [Space(20)]
    [Header("Options for another thing")]
    [Draw("Selection", DrawType.PopupList)]
    public SecondEnum SecondSelection = SecondEnum.A;

    public void OnChange()
    {
    }

    public override void Save(UnityModManager.ModEntry modEntry)
    {
        Save(this, modEntry);
    }
}

Manager version: 0.32.1.0

[newman55]

Try to assign a different label for the Draw attribute, for example, Selection 1 and Selection 2.

[jruo]

Yes that would work, but it's not something I would like to do. I'd like to have the same label and values.

This seems to be the offending line:

unity-mod-manager/UnityModManager/ToggleGroup.cs

Line 255 in 1e1e85a

if (popup is PopupToggleGroup_GUI item && (unique == 0 && item.title == title && item.values.SequenceEqual(values) || unique != 0 && item.unique == unique && item.title == title))

There is a unique value for disambiguation purposes, but I don't see any way to use it with the [Draw] attribute currently.

If I may suggest, could you maybe add something like this?:

diff --git a/UnityModManager/UIDraw.cs b/UnityModManager/UIDraw.cs
index d2b7f16..c3c2083 100644
--- a/UnityModManager/UIDraw.cs
+++ b/UnityModManager/UIDraw.cs
@@ -99,6 +99,10 @@ namespace UnityModManagerNet
     [AttributeUsage(AttributeTargets.Field, AllowMultiple = false)]
     public class DrawAttribute : Attribute
     {
+        /// <summary>
+        /// In case of a Label conflict, use this to disambiguate
+        /// </summary>
+        public int Key = 0;
         /// <summary>
         /// Specifies which GUI element to render with. By default Auto.
         /// </summary>
@@ -1195,6 +1199,7 @@ namespace UnityModManagerNet
                         foreach (DrawAttribute a_ in attributes)
                         {
                             a = a_;
+                            a.Key = a_.Key;
                             a.Width = a.Width != 0 ? Scale(a.Width) : 0;
                             a.Height = a.Height != 0 ? Scale(a.Height) : 0;
                         }
@@ -1329,7 +1334,7 @@ namespace UnityModManagerNet
                             }
                             else
                             {
-                                if (Draw(val, f.FieldType, mod, defaultMask, f.Name.GetHashCode() + unique))
+                                if (Draw(val, f.FieldType, mod, defaultMask, f.Name.GetHashCode() + unique + a.Key))
                                 {
                                     changed = true;
                                     f.SetValue(container, val);
@@ -1892,7 +1897,7 @@ namespace UnityModManagerNet
                         if (!a.Vertical)
                             GUILayout.Space(Scale(5));
                         var val = (int)f.GetValue(container);
-                        if (PopupToggleMulti(ref val, f.FieldType, fieldName, unique, null, options.ToArray()))
+                        if (PopupToggleMulti(ref val, f.FieldType, fieldName, unique + a.Key, null, options.ToArray()))
                         {
                             f.SetValue(container, val);
                             changed = true;
@@ -1926,7 +1931,7 @@ namespace UnityModManagerNet
                         var values = Enum.GetValues(f.FieldType);
                         var val = f.GetValue(container);
                         var index = Array.IndexOf(values, val);
-                        if (PopupToggleGroup(ref index, names, fieldName, unique, null, options.ToArray()))
+                        if (PopupToggleGroup(ref index, names, fieldName, unique + a.Key, null, options.ToArray()))
                         {
                             var v = Enum.Parse(f.FieldType, names[index]);
                             f.SetValue(container, v);

Then we could just

    [Header("Options for a thing")]
    [Draw("Selection", DrawType.PopupList, Key = 1)]
    public FirstEnum FirstSelection = FirstEnum.A;

    [Space(20)]
    [Header("Options for another thing")]
    [Draw("Selection", DrawType.PopupList, Key = 2)]
    public SecondEnum SecondSelection = SecondEnum.A;

And it works

[newman55]

I think it's possible.

[newman55]

I did something about your suggestion, but I didn't test it. Could you do that? UMM
I added the Unique variable.

[jruo]

It works 👍

[newman55]

I published it.