Skip to content

Commit b369db1

Browse files
update spotbugs to suppress warnings
1 parent 1ff18be commit b369db1

File tree

1 file changed

+46
-1
lines changed

1 file changed

+46
-1
lines changed

logback13/spotbugs-filter.xml

Lines changed: 46 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,57 @@
1515
<Class name="com.newrelic.logging.logback13.NewRelicAsyncAppender"/>
1616
</Match>
1717

18+
<Match>
19+
<!--
20+
We have to implement all methods of the LayoutBase<ILoggingEvent>.
21+
-->
22+
<Bug pattern="EI_EXPOSE_REP2" />
23+
<Class name="com.newrelic.logging.logback13.NewRelicJsonLayout"/>
24+
<!-- <Method name="setContext" />-->
25+
</Match>
26+
27+
<Match>
28+
<!--
29+
We have to implement all methods of the LayoutBase<ILoggingEvent>.
30+
-->
31+
<Bug pattern="EI_EXPOSE_REP" />
32+
<Class name="com.newrelic.logging.logback13.NewRelicJsonLayout"/>
33+
<Method name="getContext" />
34+
</Match>
35+
36+
<Match>
37+
<!--
38+
This method calls getCallerData() and is required to populate the stack trace in the log event,
39+
even if the return value is ignored.
40+
-->
41+
<Bug pattern="RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT" />
42+
<Class name="com.newrelic.logging.logback13.NewRelicAsyncAppender"/>
43+
<Method name="preprocess" />
44+
</Match>
45+
46+
<Match>
47+
<!--
48+
This method calls getCallerData() and is required to populate the stack trace in the log event,
49+
even if the return value is ignored.
50+
-->
51+
<Bug pattern="EI_EXPOSE_REP2" />
52+
<Class name="com.newrelic.logging.logback13.CustomLoggingEventWrapper"/>
53+
</Match>
54+
55+
<Match>
56+
<!--
57+
Using ByteArrayOutputStream is being used to write the JSON output, and run test assertions.
58+
-->
59+
<bug pattern="DM_DFAULT_ENCODING" />
60+
<Class name="com.newrelic.logging.logback13.NewRelicLogback13Tests"/>
61+
</Match>
62+
1863
<Match>
1964
<!--
2065
We have to write to a static because otherwise this value is set based on a classload.
2166
-->
2267
<Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
23-
<Class name="com.newrelic.logging.logback11.NewRelicLogback11Tests"/>
68+
<Class name="com.newrelic.logging.logback13.NewRelicLogback11Tests"/>
2469
</Match>
2570

2671
</FindBugsFilter>

0 commit comments

Comments
 (0)