77 xmlns : xsi =" http://www.w3.org/2001/XMLSchema-instance"
88 xsi : schemaLocation =" https://github.com/spotbugs/filter/3.0.0 https://raw.githubusercontent.com/spotbugs/spotbugs/3.1.0/spotbugs/etc/findbugsfilter.xsd" >
99 <Match >
10- <!--
11- This is not final so that it can be reassigned in tests to inject a mock Agent.
12- -->
1310 <Bug pattern =" MS_SHOULD_BE_FINAL" />
1411 <Class name =" com.newrelic.logging.logback13.NewRelicAsyncAppender" />
1512 </Match >
1613 <Match >
17- <!--
18- We have to write to a static because otherwise this value is set based on a classload.
19- -->
2014 <Bug pattern =" ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD" />
2115 <Class name =" com.newrelic.logging.logback13.NewRelicJsonLayoutTest" />
2216 </Match >
2317
24- <!-- <Match>-->
25- <!-- <!–-->
26- <!-- Logback 1.3.x store MDC in ContextMap instead of ThreadLocal storage.-->
27- <!-- This change requires update to MDC handling, which could possibly trigger false positives.-->
28- <!-- –>-->
29- <!-- <Bug pattern="MS_EXPOSE_REP"/>-->
30- <!-- <Class name="com.newrelic.logging.logback13.NewRelicAsyncAppender"/>-->
31- <!-- </Match>-->
32-
33- <!-- <Match>-->
34- <!-- <!–-->
35- <!-- Prevent false positives due to proper synchronization in Logback 1.3.x's async logging.-->
36- <!-- The appender correctly handles flushing and processing of log events.-->
37- <!-- –>-->
38- <!-- <Bug pattern="SWL_SLEEP_WITH_LOCK_HELD"/>-->
39- <!-- <Class name="com.newrelic.logging.logback13.*"/>-->
40- <!-- </Match>-->
41-
42- <!-- <Match>-->
43- <!-- <!–-->
44- <!-- Allow proper handling of ContextMap MDC (since it replaced using the MCDAdapter).-->
45- <!-- Ensures logging context is stored at the LoggerContext level, instead of ThreadLocal.-->
46- <!-- –>-->
47- <!-- <Bug pattern="RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT"/>-->
48- <!-- <Class name="com.newrelic.logging.logback13.NewRelicAsyncAppender"/>-->
49- <!-- </Match>-->
50-
51- <!-- <Match>-->
52- <!-- <!–-->
53- <!-- Prevent SpotBugs from flagging valid JSON encoding operations incorrectly.-->
54- <!-- Log events are properly formated before being written to the output stream.-->
55- <!-- –>-->
56- <!-- <Bug pattern="NP_NULL_ON_SOME_PATH"/>-->
57- <!-- <Class name="com.newrelic.logging.logback13.NewRelicAsyncJsonEncoder"/>-->
58- <!-- </Match>-->
5918</FindBugsFilter >
0 commit comments