Skip to content

Replace JasperCompilerPointCut with weaver instrumentation module #2854

@jtduffy

Description

@jtduffy

Description

Point cut: com.newrelic.agent.instrumentation.pointcuts.container.JasperCompilerPointCut

Instruments the following classes/methods:

org.apache.jasper.compiler.Compiler.compile(boolean, boolean) (JSP 2.0)
org.apache.jasper.compiler.Compiler.compile(boolean) (JSP 2.0, JSP 2.1)

Uses some reflection magic to extract the JSP file path and create a metric name in the form View/my_page.jsp/Compile

This point cut also creates a JasperCompilerTracer which setups RUM browser script injection. This will probably require a change to AgentBridge to expose a noticeJspCompile method that is currently called by the point cut.

The best approach is to probably create a brand new module, which will provide support for Tomcat v7+.
The target artifact is org.apache.tomcat.tomcat-jasper. For this approach, the compile(boolean, boolean) is the only method that needs to be instrumented.

Metadata

Metadata

Assignees

No one assigned

    Labels

    2Story Point Estimate

    Type

    No type

    Projects

    Status

    Reviewed

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions