Remove HandlerMethodInvokerPointCut#2977
Open
jtduffy wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2977 +/- ##
============================================
+ Coverage 70.85% 70.91% +0.05%
- Complexity 10671 10672 +1
============================================
Files 873 871 -2
Lines 42960 42931 -29
Branches 6501 6498 -3
============================================
+ Hits 30440 30444 +4
+ Misses 9591 9557 -34
- Partials 2929 2930 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Resolves #2973
Removal of the HandlerMethodInvokerPointCut. I was able to simply utilize the existing
handler-method-invoker-3.0.0module and adjust it's apply range to support the Spring 2 transaction naming that the point cut provided. The transaction naming provided by the point cut for Spring 3+ was already handled in the existing modules.handler-method-invoker-3.0.0tohandler-method-invoker-2.5.2to reflect the coverage of Spring 2.5.2SpringPointCutclass that used to exist in one if the removed point cuts