Skip to content

Remove HandlerMethodInvokerPointCut#2977

Open
jtduffy wants to merge 2 commits into
mainfrom
remove-handlermethodinvoke-pointcut
Open

Remove HandlerMethodInvokerPointCut#2977
jtduffy wants to merge 2 commits into
mainfrom
remove-handlermethodinvoke-pointcut

Conversation

@jtduffy

@jtduffy jtduffy commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Overview

Resolves #2973

Removal of the HandlerMethodInvokerPointCut. I was able to simply utilize the existing handler-method-invoker-3.0.0 module and adjust it's apply range to support the Spring 2 transaction naming that the point cut provided. The transaction naming provided by the point cut for Spring 3+ was already handled in the existing modules.

  • renamed the handler-method-invoker-3.0.0 to handler-method-invoker-2.5.2 to reflect the coverage of Spring 2.5.2
  • removed two (now) unused point cuts
  • addition of an inline constant to the SpringPointCut class that used to exist in one if the removed point cuts
  • tests to verify the new transaction naming

@codecov-commenter

codecov-commenter commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.91%. Comparing base (8cc5d6c) to head (47428fc).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...on/pointcuts/frameworks/spring/SpringPointCut.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2977      +/-   ##
============================================
+ Coverage     70.85%   70.91%   +0.05%     
- Complexity    10671    10672       +1     
============================================
  Files           873      871       -2     
  Lines         42960    42931      -29     
  Branches       6501     6498       -3     
============================================
+ Hits          30440    30444       +4     
+ Misses         9591     9557      -34     
- Partials       2929     2930       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Replace HandlerMethodInvokerPointCut point cut class with weave instrumentation

2 participants