Skip to content

Google ADK Agents Instrumentation#1767

Merged
TimPansino merged 3 commits into
develop-google-adkfrom
feat-google-adk-agent-instrumentation
Jun 24, 2026
Merged

Google ADK Agents Instrumentation#1767
TimPansino merged 3 commits into
develop-google-adkfrom
feat-google-adk-agent-instrumentation

Conversation

@TimPansino

Copy link
Copy Markdown
Contributor

Overview

  • Add instrumentation for Google ADK Agents

@TimPansino TimPansino requested a review from a team as a code owner June 16, 2026 18:47
@TimPansino TimPansino force-pushed the feat-google-adk-agent-instrumentation branch from facf5dc to 378260f Compare June 16, 2026 18:48
@mergify mergify Bot added the tests-failing Tests failing in CI. label Jun 16, 2026
@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 8 0 0 1.0s
✅ MARKDOWN markdownlint 7 0 0 0 1.48s
✅ PYTHON ruff 1044 0 0 0 1.15s
✅ PYTHON ruff-format 1044 0 0 0 0.4s
✅ YAML prettier 20 0 0 0 1.72s
✅ YAML v8r 20 0 0 6.74s
✅ YAML yamllint 20 0 0 0.79s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@TimPansino TimPansino force-pushed the feat-google-adk-agent-instrumentation branch from 75fd23d to e9f0722 Compare June 16, 2026 19:05
@mergify mergify Bot removed the tests-failing Tests failing in CI. label Jun 16, 2026
@codecov-commenter

codecov-commenter commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.53191% with 23 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop-google-adk@a7b31f7). Learn more about missing BASE report.

Files with missing lines Patch % Lines
newrelic/hooks/mlmodel_googleadk.py 75.26% 16 Missing and 7 partials ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             develop-google-adk    #1767   +/-   ##
=====================================================
  Coverage                      ?   81.65%           
=====================================================
  Files                         ?      216           
  Lines                         ?    26511           
  Branches                      ?     4180           
=====================================================
  Hits                          ?    21647           
  Misses                        ?     3453           
  Partials                      ?     1411           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread newrelic/hooks/mlmodel_googleadk.py Outdated
func_name = callable_name(wrapped)
agent_name = getattr(instance, "name", "agent")
function_trace_name = f"{func_name}/{agent_name}"
agentic_subcomponent_data = {"type": "APM-AI_AGENT", "name": agent_name}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going forward, we will ideally only want to send the subcomponent attr if we have a local agent executing (rather than an invocation by a local or remote agent). Is there a way in the ADK repo to distinguish between remote and local agents and executions vs invocations?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remote agents are handled by a separate class entirely, and it looks like there's a parent_agent field on all agents that can determine if this is a sub agent and not a top level agent.

Comment thread newrelic/hooks/mlmodel_googleadk.py
@mergify mergify Bot added tests-failing Tests failing in CI. and removed tests-failing Tests failing in CI. labels Jun 24, 2026
@mergify

mergify Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@TimPansino TimPansino merged commit fef8ce4 into develop-google-adk Jun 24, 2026
106 of 108 checks passed
@TimPansino TimPansino deleted the feat-google-adk-agent-instrumentation branch June 24, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants