Skip to content

Commit 399f0bc

Browse files
newstlerclaude
andcommitted
Use bin/brakeman in CI so warnings fail the build
bin/ci was using `brakeman -q --no-exit-on-warn` which silently passed on warnings, while GitHub CI ran `bin/brakeman` which exits non-zero. Now both use the same command. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent e938e08 commit 399f0bc

File tree

6 files changed

+6
-6
lines changed

6 files changed

+6
-6
lines changed

.claude/agents/rails-backend.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,5 +113,5 @@ Before completing any task:
113113
```bash
114114
bundle exec rubocop -A # Fix lint issues
115115
rails test # Run tests
116-
bundle exec brakeman -q # Security check
116+
bin/brakeman --no-pager # Security check
117117
```

.claude/commands/commit-push-pr.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ Before committing, ensure code quality:
2121
```bash
2222
bundle exec rubocop -A
2323
rails test
24-
bundle exec brakeman -q --no-pager
24+
bin/brakeman --no-pager
2525
```
2626

2727
If any quality gate fails, fix the issues before proceeding.

.claude/commands/review-code.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ git diff --cached # If already staged
6565
```bash
6666
bundle exec rubocop -A
6767
rails test
68-
bundle exec brakeman -q --no-pager
68+
bin/brakeman --no-pager
6969
```
7070

7171
## 4. Common Issues

.claude/commands/run-tests.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ Action: Method doesn't exist, check model implementation.
9393
If all tests pass:
9494
```bash
9595
bundle exec rubocop -A
96-
bundle exec brakeman -q
96+
bin/brakeman --no-pager
9797
```
9898

9999
If tests fail:

AGENTS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ Before ANY commit:
235235

236236
```bash
237237
bin/ci
238-
# or: bundle exec rubocop -A && rails test && bundle exec brakeman -q
238+
# or: bundle exec rubocop -A && rails test && bin/brakeman --no-pager
239239
```
240240

241241
All must pass. No exceptions.

bin/ci

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ echo "✅ Tests complete"
2020
echo ""
2121

2222
echo "🔒 Step 4/5: Running Brakeman security scan..."
23-
bundle exec brakeman -q --no-pager --no-exit-on-warn
23+
bin/brakeman --no-pager
2424
echo "✅ Security scan complete"
2525
echo ""
2626

0 commit comments

Comments
 (0)