Fix UpdateGithubDataJob email validation failures (#138)

* fix(jobs): allow blank email on users, remove unused NotifyAdminJob

UpdateGithubDataJob was failing for ~50% of users because GitHub's
GraphQL API returns nil for private emails, triggering the email
presence validation. Relaxed to allow_blank since this is OAuth-only.

Removed NotifyAdminJob, AdminMailer, and associated views as they
were unused beyond logging (which the job already does).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(db): remove unique constraint on users.email

Multiple GitHub users have nil/blank emails (private email setting).
The database-level UNIQUE index caused SQLite3::ConstraintException
for these users during batch updates.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: newstler

app/jobs/notify_admin_job.rb

@@ -30,13 +30,5 @@ def perform
     if all_errors.any?
       Rails.logger.warn "Errors encountered: #{all_errors.first(10).join(', ')}#{all_errors.size > 10 ? '...' : ''}"
     end
-
-    # Notify admin if there were significant failures
-    if total_failed > 5 && defined?(NotifyAdminJob)
-      NotifyAdminJob.perform_later(
-        subject: "GitHub Data Update Report",
-        message: "GitHub data update completed with #{total_failed} failures out of #{total_updated + total_failed} total users."
-      )
-    end
   end
 end

app/jobs/update_github_data_job.rb

@@ -98,7 +98,6 @@ def create_slug_history
   def auto_hide_if_needed!
     if reports_count >= 3
       update!(needs_admin_review: true, published: false)
-      NotifyAdminJob.perform_later(self)
     end
   end
 

app/mailers/admin_mailer.rb

@@ -32,7 +32,7 @@ class User < ApplicationRecord
   validates :github_id, presence: true, uniqueness: true
   validates :username, presence: true, uniqueness: true
   validates :slug, uniqueness: true, allow_blank: true
-  validates :email, presence: true, uniqueness: true
+  validates :email, uniqueness: true, allow_blank: true
 
   # Scopes
   scope :trusted, -> {

app/models/post.rb

@@ -0,0 +1,6 @@
+class RemoveUniqueIndexOnUsersEmail < ActiveRecord::Migration[8.2]
+  def change
+    remove_index :users, :email, unique: true
+    add_index :users, :email
+  end
+end