Skip to content
This repository was archived by the owner on Jul 6, 2022. It is now read-only.

feat: add info about cookie chunking#100

Merged
balazsorban44 merged 4 commits into
mainfrom
ndom91/update-cookie-info
Nov 15, 2021
Merged

feat: add info about cookie chunking#100
balazsorban44 merged 4 commits into
mainfrom
ndom91/update-cookie-info

Conversation

@ndom91
Copy link
Copy Markdown
Member

@ndom91 ndom91 commented Nov 6, 2021

Changes 💡

Adds info regarding the cookie chunking PR (nextauthjs/next-auth#3101). These were the two places that seemed like obvious candidates for more info, feel free to add on to it obviously 👍

Affected issues 🎟

Fixes #99

Screenshot (If Applicable) 📷

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/docs/DM82HQMfG5W6Uj9uvizXUfoz91hB
✅ Preview: https://docs-git-ndom91-update-cookie-info-nextauthjs.vercel.app

Copy link
Copy Markdown
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also mention to allow session cookies if you are using a proxy.

Comment thread docs/configuration/options.md Outdated
Comment thread docs/faq.md Outdated
Comment thread docs/faq.md Outdated
JSON Web Tokens can be used for session tokens if enabled with `session: { jwt: true }` option. JSON Web Tokens are enabled by default if you have not specified a database.

By default JSON Web Tokens are signed (JWS) but not encrypted (JWE), as JWT encryption adds additional overhead and comes with some caveats. You can enable encryption by setting `encryption: true`.
By default JSON Web Tokens are not signed (JWS) but are encrypted (JWE).
Copy link
Copy Markdown
Member

@balazsorban44 balazsorban44 Nov 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I realize now, this could have been addressed in a separate PR fixing #87. 😅

Copy link
Copy Markdown
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, #87 concerns can be addressed in a separate PR. Let's wait with merging until nextauthjs/next-auth#3101 is merged as well. Finishing testing on that one at production at work, everything seems to be working correctly there. Will double-check on Monday.

@balazsorban44 balazsorban44 merged commit 07ba887 into main Nov 15, 2021
@balazsorban44 balazsorban44 deleted the ndom91/update-cookie-info branch November 15, 2021 09:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document session cookie chunking

2 participants