Skip to content

feat(adapters): add remult adapter#11762

Open
jycouet wants to merge 18 commits into
nextauthjs:mainfrom
jycouet:feat/remult-adapter
Open

feat(adapters): add remult adapter#11762
jycouet wants to merge 18 commits into
nextauthjs:mainfrom
jycouet:feat/remult-adapter

Conversation

@jycouet
Copy link
Copy Markdown
Contributor

@jycouet jycouet commented Sep 3, 2024

☕️ Reasoning

Adding a new adapter @auth/remult-adapter

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged
    • @noam-honig I would like you to check it before adding "ready"

🎫 Affected issues

📌 Resources

@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 5:22pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2024 5:22pm

@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 3, 2024

@jycouet is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the adapters Changes related to the core code concerning database adapters label Sep 3, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 3, 2024

Broken Link Checker

0 broken links found. Links organised below by source page, or page where they were found.

@balazsorban44 balazsorban44 changed the title Feat - remult adapter feat(adapters): add remult adapter Sep 4, 2024
@jycouet jycouet marked this pull request as draft September 4, 2024 13:35
@jycouet
Copy link
Copy Markdown
Contributor Author

jycouet commented Sep 12, 2024

hi @ubbe-xyz @ndom91 @ThangHuuVu @balazsorban44
Please let me know if you need anything else to proceed.

@noam-honig
Copy link
Copy Markdown
Contributor

As the creator of remult - this looks great, can't wait for this to get merged

@yoni-rapoport
Copy link
Copy Markdown

As the creator of remult - this looks great, can't wait for this to get merged

+1

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 8, 2024

Codecov Report

❌ Patch coverage is 96.89579% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.13%. Comparing base (e91073f) to head (749cf8f).
⚠️ Report is 217 commits behind head on main.

Files with missing lines Patch % Lines
packages/adapter-remult/src/index.ts 95.30% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11762      +/-   ##
==========================================
+ Coverage   39.05%   40.13%   +1.07%     
==========================================
  Files         191      193       +2     
  Lines       29994    30303     +309     
  Branches     1294     1355      +61     
==========================================
+ Hits        11715    12162     +447     
+ Misses      18279    18141     -138     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jycouet

This comment was marked as outdated.

@jycouet

This comment was marked as outdated.

@jycouet
Copy link
Copy Markdown
Contributor Author

jycouet commented Oct 18, 2024

Tadaaa 🥳
All green, I guess that @balazsorban44 you would need to allow Vercel to be 100%

Then ready to merge? :)

@jycouet
Copy link
Copy Markdown
Contributor Author

jycouet commented Nov 10, 2024

@balazsorban44 we had a few users requesting it. Could you have a look and validate this adapter ? :)
Thank you

@shiftlabs1
Copy link
Copy Markdown

@balazsorban44 we need this please. We will appreciate your looking into and authorising the merge. Thanks

@jycouet
Copy link
Copy Markdown
Contributor Author

jycouet commented Jan 14, 2025

@balazsorban44 should I resolve conflicts ?

@ermincelikovic
Copy link
Copy Markdown

Authjs team, any updates on this?
Anything we can do to help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adapters Changes related to the core code concerning database adapters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants