Skip to content

feat(react): preserve history on client-side navigation#2980

Merged
balazsorban44 merged 4 commits into
betafrom
feat/preserve-history
Oct 29, 2021
Merged

feat(react): preserve history on client-side navigation#2980
balazsorban44 merged 4 commits into
betafrom
feat/preserve-history

Conversation

@balazsorban44
Copy link
Copy Markdown
Member

@balazsorban44 balazsorban44 commented Oct 18, 2021 •
edited
Loading

Fixes #2676

Using window.location.href instead of window.location.replace as pointed out by @ndom91 in #2676 (comment) will preserve the history.

@balazsorban44 balazsorban44 requested a review from ndom91 October 18, 2021 09:25
@github-actions github-actions Bot added the core Refers to `@auth/core` label Oct 18, 2021
@github-actions github-actions Bot added the client Client related code label Oct 18, 2021
@balazsorban44 balazsorban44 temporarily deployed to Preview October 18, 2021 11:05 Inactive
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 18, 2021 •
edited by codecov Bot
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 13.71%. Comparing base (c089ede) to head (5d820d1).

Additional details and impacted files 
@@           Coverage Diff           @@
##             beta    #2980   +/-   ##
=======================================
  Coverage   13.71%   13.71%           
=======================================
  Files          86       86           
  Lines        1356     1356           
  Branches      374      374           
=======================================
  Hits          186      186           
  Misses       1161     1161           
  Partials        9        9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 18, 2021

🎉 Experimental release published on npm!

npm i next-auth@0.0.0-pr.2980.c0b78cd9
yarn add next-auth@0.0.0-pr.2980.c0b78cd9

@balazsorban44 balazsorban44 mentioned this pull request Oct 18, 2021
Closed
ndom91
ndom91 approved these changes Oct 27, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@ndom91 ndom91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@balazsorban44
Merge branch 'beta'
5d820d1 
Conflicts:
	package-lock.json
@balazsorban44 balazsorban44 merged commit 1d9b7b8 into beta Oct 29, 2021
@balazsorban44 balazsorban44 deleted the feat/preserve-history branch October 29, 2021 10:55
mnphpexpert added a commit to mnphpexpert/next-auth that referenced this pull request Sep 2, 2024
@mnphpexpert
feat(react): preserve history on client-side navigation (nextauthjs#2980
db7fc2a 
)

* feat(react): preserve history on client-side navigation

* chore(deps): upgrade jest

* test(client): use absolute URL since `whatwg-*` refusing relative URLs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndom91 ndom91 ndom91 approved these changes

Assignees

No one assigned

Labels

client Client related code core Refers to `@auth/core`

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@balazsorban44 @codecov-commenter @ndom91 @mcg