Skip to content

refactor: use universal modules in next-auth/jwt#3062

Merged
balazsorban44 merged 1 commit into
nextauthjs:betafrom
panva:universal-jwt
Oct 29, 2021
Merged

refactor: use universal modules in next-auth/jwt#3062
balazsorban44 merged 1 commit into
nextauthjs:betafrom
panva:universal-jwt

Conversation

@panva
Copy link
Copy Markdown
Contributor

@panva panva commented Oct 29, 2021

This updates the src/jwt/index.ts module to only use universal modules for uuid and hkdf (in addition to already universal jose) to get around bundle issues and sizes towards #3037

@github-actions github-actions Bot added the core Refers to `@auth/core` label Oct 29, 2021
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 29, 2021

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 13.71%. Comparing base (5725931) to head (f78c344).

Files with missing lines Patch % Lines
src/jwt/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             beta    #3062      +/-   ##
==========================================
+ Coverage   13.62%   13.71%   +0.09%     
==========================================
  Files          86       86              
  Lines        1365     1356       -9     
  Branches      378      374       -4     
==========================================
  Hits          186      186              
+ Misses       1170     1161       -9     
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@balazsorban44 balazsorban44 changed the title refactor: use universal modules in src/jwt/index.ts refactor: use universal modules in next-auth/jwt Oct 29, 2021
@balazsorban44 balazsorban44 merged commit c089ede into nextauthjs:beta Oct 29, 2021
mnphpexpert added a commit to mnphpexpert/next-auth that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Refers to `@auth/core`

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants