chore(ci): pin surrealdb test server to the v2 image for the 1.3 client#13468
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13468 +/- ##
==========================================
- Coverage 59.36% 49.85% -9.52%
==========================================
Files 119 200 +81
Lines 2018 13487 +11469
Branches 340 1445 +1105
==========================================
+ Hits 1198 6724 +5526
- Misses 820 6763 +5943 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SurrealDB adapter's test bootstrap picked its Docker image tag by scraping the first page of Docker Hub's tag list for the newest
v2.xrelease. That list has since filled up withrolling-*,nightly, andv3.xtags, so everyv2.xtag has aged off page one and the scrape now returns nothing. With an empty tag, the script runsdocker run surrealdb/surrealdb: start ..., which Docker rejects withinvalid reference format. No server ever starts, so the test'sdb.connect("ws://0.0.0.0:8000")fails withECONNREFUSED, and the client's version probe against the unreachable host produces a misleading "Unexpected token '<'" log that just reflects the missing server, not a separate bug.This replaces the registry scrape with the floating
surrealdb/surrealdb:v2tag, which resolves to a current v2 release compatible with the pinned 1.3.x JS client. It also swaps the blind 5-second sleep for a poll against the server's/healthendpoint and uses atrap ... EXITto guarantee the container stops while preserving the test suite's exit code underset -euo pipefail. No runtime source, dependency, or published package changes; this only fixes the test bootstrap script.