Skip to content

chore(ci): pin surrealdb test server to the v2 image for the 1.3 client#13468

Merged
gustavovalverde merged 1 commit into
mainfrom
chore/main-surrealdb-ci-repair
Jul 20, 2026
Merged

chore(ci): pin surrealdb test server to the v2 image for the 1.3 client#13468
gustavovalverde merged 1 commit into
mainfrom
chore/main-surrealdb-ci-repair

Conversation

@gustavovalverde

Copy link
Copy Markdown
Collaborator

The SurrealDB adapter's test bootstrap picked its Docker image tag by scraping the first page of Docker Hub's tag list for the newest v2.x release. That list has since filled up with rolling-*, nightly, and v3.x tags, so every v2.x tag has aged off page one and the scrape now returns nothing. With an empty tag, the script runs docker run surrealdb/surrealdb: start ..., which Docker rejects with invalid reference format. No server ever starts, so the test's db.connect("ws://0.0.0.0:8000") fails with ECONNREFUSED, and the client's version probe against the unreachable host produces a misleading "Unexpected token '<'" log that just reflects the missing server, not a separate bug.

This replaces the registry scrape with the floating surrealdb/surrealdb:v2 tag, which resolves to a current v2 release compatible with the pinned 1.3.x JS client. It also swaps the blind 5-second sleep for a poll against the server's /health endpoint and uses a trap ... EXIT to guarantee the container stops while preserving the test suite's exit code under set -euo pipefail. No runtime source, dependency, or published package changes; this only fixes the test bootstrap script.

@vercel

vercel Bot commented Jul 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
auth-docs Ready Ready Preview, Comment Jul 20, 2026 8:56pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
next-auth-docs Ignored Ignored Jul 20, 2026 8:56pm
proxy Ignored Ignored Jul 20, 2026 8:56pm

Request Review

@github-actions github-actions Bot added adapters Changes related to the core code concerning database adapters surrealdb labels Jul 20, 2026
@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.85%. Comparing base (1116034) to head (e3ad860).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13468      +/-   ##
==========================================
- Coverage   59.36%   49.85%   -9.52%     
==========================================
  Files         119      200      +81     
  Lines        2018    13487   +11469     
  Branches      340     1445    +1105     
==========================================
+ Hits         1198     6724    +5526     
- Misses        820     6763    +5943     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gustavovalverde
gustavovalverde merged commit 5b1aa47 into main Jul 20, 2026
13 of 15 checks passed
@gustavovalverde
gustavovalverde deleted the chore/main-surrealdb-ci-repair branch July 20, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adapters Changes related to the core code concerning database adapters surrealdb

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant