fix: fetch token using @nextcloud/auth which updates the token on context#913
Merged
fix: fetch token using @nextcloud/auth which updates the token on context#913
@nextcloud/auth which updates the token on context#913Conversation
susnux
commented
Apr 14, 2026
susnux
force-pushed
the
fix/fetch-and-set-token
branch
from
82cb998 to
91a8850
Compare
…ontext When a new token needs to be fetched we should use the function from the library which automatically also sets the new token on the current context (global state). It also handles calling the on-token-update events. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/fetch-and-set-token
branch
from
91a8850 to
96588b9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #913 +/- ##
=======================================
Coverage 87.30% 87.30%
=======================================
Files 5 5
Lines 63 63
Branches 19 19
=======================================
Hits 55 55
Misses 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pringelmann
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setRequestTokenandfetchRequestTokenmethods nextcloud-auth#900When a new token needs to be fetched we should use the function from the library which automatically also sets the new token on the current context (global state).
It also handles calling the on-token-update events.