chore: drop cjs and migrate building to vanilla Typescript#919
Merged
Conversation
All tools we use for bundling nowadays support Javascript modules. So no need for commonjs anymore. With this simplification we also can migrate to vanilla Typescript compiler for transpiling the library. Vite is not really needed here as the app bundler will take care of transpiling unsupported syntax (es version) etc. Moreover there is no real performance difference, especially comparing tsgo with rolldown-vite or tsdown does not make much of a difference. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #919 +/- ##
=======================================
Coverage 87.30% 87.30%
=======================================
Files 5 5
Lines 63 63
Branches 19 19
=======================================
Hits 55 55
Misses 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
artonge
approved these changes
Apr 16, 2026
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
Always up for simplify our systems :)
ShGKme
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All tools we use for bundling nowadays support Javascript modules. So no need for commonjs anymore.
With this simplification we also can migrate to vanilla Typescript compiler for transpiling the library.
Vite is not really needed here as the app bundler will take care of transpiling unsupported syntax (es version) etc.
Moreover there is no real performance difference, especially comparing tsgo with rolldown-vite or tsdown does not make much of a difference.