From 3d76ec02dcfad54425f6b97853f873bb0e6c096f Mon Sep 17 00:00:00 2001
From: Ferdinand Thiessen <opensource@fthiessen.de>
Date: Wed, 17 Dec 2025 00:34:40 +0100
Subject: [PATCH 1/2] fix(filepicker): use proper folder icons

We need AccountGroup instead of just Group (wrong icon).
Also its the key icon instead of the lock icon for encryption (to be
inline with files app).

Also use outlines icons.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
---
 lib/components/FilePicker/FilePreview.vue | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/lib/components/FilePicker/FilePreview.vue b/lib/components/FilePicker/FilePreview.vue
index 12d7213bb..b5a461cc1 100644
--- a/lib/components/FilePicker/FilePreview.vue
+++ b/lib/components/FilePicker/FilePreview.vue
@@ -23,7 +23,7 @@
 <script setup lang="ts">
 import type { INode } from '@nextcloud/files'
 
-import { mdiAccountPlus, mdiGroup, mdiLink, mdiLock, mdiNetwork, mdiTag } from '@mdi/js'
+import { mdiAccountGroupOutline, mdiAccountPlus, mdiKey, mdiLink, mdiNetworkOutline, mdiTagOutline } from '@mdi/js'
 import { FileType } from '@nextcloud/files'
 import { ShareType } from '@nextcloud/sharing'
 import { computed, ref, toRef } from 'vue'
@@ -57,12 +57,12 @@ const folderDecorationIcon = computed(() => {
 
 	// Encrypted folders
 	if (props.node.attributes?.['is-encrypted'] === 1) {
-		return mdiLock
+		return mdiKey
 	}
 
 	// System tags
 	if (props.node.attributes?.['is-tag']) {
-		return mdiTag
+		return mdiTagOutline
 	}
 
 	// Link and mail shared folders
@@ -77,13 +77,13 @@ const folderDecorationIcon = computed(() => {
 	}
 
 	switch (props.node.attributes?.['mount-type']) {
-	case 'external':
-	case 'external-session':
-		return mdiNetwork
-	case 'group':
-		return mdiGroup
-	case 'shared':
-		return mdiAccountPlus
+		case 'external':
+		case 'external-session':
+			return mdiNetworkOutline
+		case 'group':
+			return mdiAccountGroupOutline
+		case 'shared':
+			return mdiAccountPlus
 	}
 
 	return null

From b40c0b09f08392bdf0930737e2670606b62887c2 Mon Sep 17 00:00:00 2001
From: Ferdinand Thiessen <opensource@fthiessen.de>
Date: Wed, 17 Dec 2025 14:42:15 +0100
Subject: [PATCH 2/2] chore: fix linting issues

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
---
 .github/workflows/lint-eslint.yml             | 51 +++++++++++++++++++
 lib/components/FilePicker/FileListRow.spec.ts | 18 ++++---
 .../FilePicker/FilePickerBreadcrumbs.vue      | 22 ++++----
 lib/components/FilePicker/FilePreview.vue     | 14 ++---
 lib/components/PublicAuthPrompt.vue           |  8 +--
 lib/utils/guestNameValidity.ts                | 22 ++++----
 6 files changed, 94 insertions(+), 41 deletions(-)
 create mode 100644 .github/workflows/lint-eslint.yml

diff --git a/.github/workflows/lint-eslint.yml b/.github/workflows/lint-eslint.yml
new file mode 100644
index 000000000..558c74431
--- /dev/null
+++ b/.github/workflows/lint-eslint.yml
@@ -0,0 +1,51 @@
+# This workflow is provided via the organization template repository
+#
+# https://github.com/nextcloud-libraries/.github
+# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
+#
+# SPDX-FileCopyrightText: 2021-2024 Nextcloud GmbH and Nextcloud contributors
+# SPDX-License-Identifier: MIT
+
+name: Lint eslint
+
+on: pull_request
+
+permissions:
+  contents: read
+
+concurrency:
+  group: lint-eslint-${{ github.head_ref || github.run_id }}
+  cancel-in-progress: true
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+
+    name: eslint
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
+        with:
+          persist-credentials: false
+
+      - name: Read package.json
+        uses: nextcloud-libraries/parse-package-engines-action@122ae05d4257008180a514e1ddeb0c1b9d094bdd # v0.1.0
+        id: versions
+
+      - name: Set up node
+        uses: actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f # v6.1.0
+        with:
+          node-version: ${{ steps.versions.outputs.node-version }}
+
+      - name: Set up npm
+        run: npm i -g 'npm@${{ steps.versions.outputs.package-manager-version }}'
+
+      - name: Install dependencies
+        env:
+          CYPRESS_INSTALL_BINARY: 0
+          PUPPETEER_SKIP_DOWNLOAD: true
+        run: npm ci
+
+      - name: Lint
+        run: npm run lint
diff --git a/lib/components/FilePicker/FileListRow.spec.ts b/lib/components/FilePicker/FileListRow.spec.ts
index 3004cfc3d..c8ff51f13 100644
--- a/lib/components/FilePicker/FileListRow.spec.ts
+++ b/lib/components/FilePicker/FileListRow.spec.ts
@@ -3,7 +3,7 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
-import type { VueWrapper } from '@vue/test-utils'
+import type { Wrapper } from '@vue/test-utils'
 import type { ComponentProps } from 'vue-component-type-helpers'
 
 import { afterEach, describe, expect, it, vi } from 'vitest'
@@ -13,25 +13,27 @@ import { shallowMount } from '@vue/test-utils'
 import FileListRow from './FileListRow.vue'
 import { nextTick } from 'vue'
 
-type SubmitAction = (wrapper: VueWrapper<any>) => Promise<void>
+/* eslint-disable @typescript-eslint/no-explicit-any, jsdoc/require-jsdoc */
+
+type SubmitAction = (wrapper: Wrapper<any>) => Promise<void>
 type ElementEvent = { 'update:selected': boolean | undefined, 'enter-directory': Folder | undefined }
 
-async function clickCheckboxAction(wrapper: VueWrapper<any>) {
+async function clickCheckboxAction(wrapper: Wrapper<any>) {
 	wrapper.find('input[type="checkbox"]').trigger('click')
 }
 
-async function clickElementAction(wrapper: VueWrapper<any>) {
+async function clickElementAction(wrapper: Wrapper<any>) {
 	wrapper.find('[data-testid="row-name"]').trigger('click')
 }
 
-async function pressEnterAction(wrapper: VueWrapper<any>) {
+async function pressEnterAction(wrapper: Wrapper<any>) {
 	wrapper.element.dispatchEvent(new KeyboardEvent('keydown', { bubbles: true, key: 'Enter' }))
 	await nextTick()
 }
 
 function testSubmitNode(name: string, propsData: ComponentProps<typeof FileListRow>, eventPayload: ElementEvent, actionCallback: SubmitAction) {
 	it(name, async () => {
-		const wrapper = shallowMount(FileListRow, {
+		const wrapper = shallowMount(FileListRow as any, {
 			propsData,
 			stubs: {
 				NcCheckboxRadioSwitch: {
@@ -113,7 +115,7 @@ describe('FilePicker: FileListRow', () => {
 		const consoleWarn = vi.spyOn(console, 'warn')
 		const consoleError = vi.spyOn(console, 'error')
 
-		const wrapper = shallowMount(FileListRow, {
+		const wrapper = shallowMount(FileListRow as any, {
 			propsData: {
 				allowPickDirectory: true,
 				selected: false,
@@ -134,7 +136,7 @@ describe('FilePicker: FileListRow', () => {
 	})
 
 	it('shows checkbox based on `showCheckbox` property', async () => {
-		const wrapper = shallowMount(FileListRow, {
+		const wrapper = shallowMount(FileListRow as any, {
 			propsData: {
 				allowPickDirectory: true,
 				selected: false,
diff --git a/lib/components/FilePicker/FilePickerBreadcrumbs.vue b/lib/components/FilePicker/FilePickerBreadcrumbs.vue
index a12ff82c4..6e34adb9f 100644
--- a/lib/components/FilePicker/FilePickerBreadcrumbs.vue
+++ b/lib/components/FilePicker/FilePickerBreadcrumbs.vue
@@ -101,17 +101,17 @@ function validateInput() {
 		}
 
 		switch (error.reason) {
-			case InvalidFilenameErrorReason.Character:
-				validity = t('"{char}" is not allowed inside a folder name.', { char: error.segment })
-				break
-			case InvalidFilenameErrorReason.ReservedName:
-				validity = t('"{segment}" is a reserved name and not allowed for folder names.', { segment: error.segment })
-				break
-			case InvalidFilenameErrorReason.Extension:
-				validity = t('Folder names must not end with "{extension}".', { extension: error.segment })
-				break
-			default:
-				validity = t('Invalid folder name.')
+		case InvalidFilenameErrorReason.Character:
+			validity = t('"{char}" is not allowed inside a folder name.', { char: error.segment })
+			break
+		case InvalidFilenameErrorReason.ReservedName:
+			validity = t('"{segment}" is a reserved name and not allowed for folder names.', { segment: error.segment })
+			break
+		case InvalidFilenameErrorReason.Extension:
+			validity = t('Folder names must not end with "{extension}".', { extension: error.segment })
+			break
+		default:
+			validity = t('Invalid folder name.')
 		}
 	}
 	if (input) {
diff --git a/lib/components/FilePicker/FilePreview.vue b/lib/components/FilePicker/FilePreview.vue
index b5a461cc1..3df784593 100644
--- a/lib/components/FilePicker/FilePreview.vue
+++ b/lib/components/FilePicker/FilePreview.vue
@@ -77,13 +77,13 @@ const folderDecorationIcon = computed(() => {
 	}
 
 	switch (props.node.attributes?.['mount-type']) {
-		case 'external':
-		case 'external-session':
-			return mdiNetworkOutline
-		case 'group':
-			return mdiAccountGroupOutline
-		case 'shared':
-			return mdiAccountPlus
+	case 'external':
+	case 'external-session':
+		return mdiNetworkOutline
+	case 'group':
+		return mdiAccountGroupOutline
+	case 'shared':
+		return mdiAccountPlus
 	}
 
 	return null
diff --git a/lib/components/PublicAuthPrompt.vue b/lib/components/PublicAuthPrompt.vue
index 886df1423..26539358b 100644
--- a/lib/components/PublicAuthPrompt.vue
+++ b/lib/components/PublicAuthPrompt.vue
@@ -22,12 +22,12 @@
 
 		<!-- Form -->
 		<NcTextField ref="input"
+			v-model="name"
 			class="public-auth-prompt__input"
 			data-cy-public-auth-prompt-dialog-name
 			:label="t('Name')"
 			:placeholder="t('Enter your name')"
 			:required="!cancellable"
-			v-model="name"
 			minlength="2"
 			maxlength="64"
 			name="name" />
@@ -114,14 +114,14 @@ export default defineComponent({
 		},
 	},
 
+	emits: ['close'],
+
 	setup() {
 		return {
 			t,
 		}
 	},
 
-	emits: ['close'],
-
 	data() {
 		return {
 			name: '',
@@ -172,7 +172,7 @@ export default defineComponent({
 			},
 			immediate: true,
 		},
-		
+
 		name() {
 			// Check validity of the new name
 			const newName = this.name.trim?.() || ''
diff --git a/lib/utils/guestNameValidity.ts b/lib/utils/guestNameValidity.ts
index cc4ae83a5..f1d5f345f 100644
--- a/lib/utils/guestNameValidity.ts
+++ b/lib/utils/guestNameValidity.ts
@@ -33,17 +33,17 @@ export function getGuestNameValidity(name: string): string {
 		}
 
 		switch (error.reason) {
-			case InvalidFilenameErrorReason.Character:
-				return t('"{char}" is not allowed inside a name.', { char: error.segment })
-			case InvalidFilenameErrorReason.ReservedName:
-				return t('"{segment}" is a reserved name and not allowed.', { segment: error.segment })
-			case InvalidFilenameErrorReason.Extension:
-				if (error.segment.match(/\.[a-z]/i)) {
-					return t('"{extension}" is not an allowed name.', { extension: error.segment })
-				}
-				return t('Names must not end with "{extension}".', { extension: error.segment })
-			default:
-				return t('Invalid name.')
+		case InvalidFilenameErrorReason.Character:
+			return t('"{char}" is not allowed inside a name.', { char: error.segment })
+		case InvalidFilenameErrorReason.ReservedName:
+			return t('"{segment}" is a reserved name and not allowed.', { segment: error.segment })
+		case InvalidFilenameErrorReason.Extension:
+			if (error.segment.match(/\.[a-z]/i)) {
+				return t('"{extension}" is not an allowed name.', { extension: error.segment })
+			}
+			return t('Names must not end with "{extension}".', { extension: error.segment })
+		default:
+			return t('Invalid name.')
 		}
 	}
 }