fix: also validate Node data on setter

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Author: skjnldsv

__tests__/files/node.spec.ts

@@ -314,9 +314,8 @@ describe('Sanity checks', () => {
 
 	test('Invalid source', () => {
 		expect(() => new File({} as unknown as NodeData)).toThrowError('Missing mandatory source')
-		expect(() => new File({
+		expect(() => new Folder({
 			source: 'cloud.domain.com/remote.php/dav/Photos',
-			mime: 'image/jpeg',
 			owner: 'emma',
 		})).toThrowError('Invalid source')
 		expect(() => new File({
@@ -332,27 +331,41 @@ describe('Sanity checks', () => {
 	})
 
 	test('Invalid displayname', () => {
-		expect(() => new File({
+		expect(() => new Folder({
 			source: 'https://cloud.domain.com/remote.php/dav/Photos',
-			mime: 'image',
 			displayname: true as unknown as string,
 			owner: 'emma',
 		})).toThrowError('Invalid displayname type')
+		
+		const file = new Folder({
+			source: 'https://cloud.domain.com/remote.php/dav/Photos',
+			displayname: 'test',
+			owner: 'emma',
+		})
+		// @ts-expect-error wrong type error check
+		expect(() => file.displayname = true).toThrowError('Invalid displayname')
 	})
+	
 
 	test('Invalid mtime', () => {
 		expect(() => new File({
-			source: 'https://cloud.domain.com/remote.php/dav/Photos',
-			mime: 'image',
+			source: 'https://cloud.domain.com/remote.php/dav/Photos/picture.jpg',
 			owner: 'emma',
 			mtime: 'invalid' as unknown as Date,
 		})).toThrowError('Invalid mtime type')
+
+		const file = new File({
+			source: 'https://cloud.domain.com/remote.php/dav/Photos/picture.jpg',
+			owner: 'emma',
+		})
+		// @ts-expect-error wrong type error check
+		expect(() => file.mtime = 'invalid').toThrowError('Invalid mtime type')
 	})
 
 	test('Invalid crtime', () => {
 		expect(() => new File({
-			source: 'https://cloud.domain.com/remote.php/dav/Photos',
-			mime: 'image',
+			source: 'https://cloud.domain.com/remote.php/dav/Photos/picture.jpg',
+			mime: 'image/jpeg',
 			owner: 'emma',
 			crtime: 'invalid' as unknown as Date,
 		})).toThrowError('Invalid crtime type')
@@ -364,6 +377,15 @@ describe('Sanity checks', () => {
 			mime: 'image',
 			owner: 'emma',
 		})).toThrowError('Missing or invalid mandatory mime')
+
+		const file = new File({
+			source: 'https://cloud.domain.com/remote.php/dav/files/emma/Photos/picture.jpg',
+			mime: 'image/jpeg',
+			owner: 'emma',
+		})
+		// @ts-expect-error wrong type error check
+		expect(() => file.mime = 1234).toThrowError('Missing or invalid mandatory mime')
+		expect(() => file.mime = 'image').toThrowError('Missing or invalid mandatory mime')
 	})
 
 	test('Invalid attributes', () => {
@@ -391,6 +413,14 @@ describe('Sanity checks', () => {
 			owner: 'emma',
 			size: 'test' as unknown as number,
 		})).toThrowError('Invalid size type')
+
+		const file = new File({
+			source: 'https://cloud.domain.com/remote.php/dav/files/emma/Photos/picture.jpg',
+			mime: 'image/jpeg',
+			owner: 'emma',
+		})
+		// @ts-expect-error wrong type error check
+		expect(() => file.size = 'test').toThrowError('Invalid size type')
 	})
 
 	test('Invalid owner', () => {
@@ -438,6 +468,15 @@ describe('Sanity checks', () => {
 			owner: 'emma',
 			status: 'invalid' as unknown as NodeStatus,
 		})).toThrowError('Status must be a valid NodeStatus')
+
+		const file = new File({
+			source: 'https://cloud.domain.com/remote.php/dav/files/emma/Photos/picture.jpg',
+			mime: 'image/jpeg',
+			owner: 'emma',
+			status: NodeStatus.LOCKED,
+		})
+		// @ts-expect-error wrong type error check
+		expect(() => file.status = 'invalid').toThrowError('Status must be a valid NodeStatus')
 	})
 })
 

lib/files/node.ts

@@ -125,6 +125,7 @@ export abstract class Node {
 	 * Set the displayname
 	 */
 	set displayname(displayname: string) {
+		validateData({ ...this._data, displayname }, this._knownDavService)
 		this._data.displayname = displayname
 	}
 
@@ -201,6 +202,7 @@ export abstract class Node {
 	 * Set the file modification time
 	 */
 	set mtime(mtime: Date|undefined) {
+		validateData({ ...this._data, mtime }, this._knownDavService)
 		this._data.mtime = mtime
 	}
 
@@ -223,6 +225,7 @@ export abstract class Node {
 	 * Set the file size
 	 */
 	set size(size: number|undefined) {
+		validateData({ ...this._data, size }, this._knownDavService)
 		this.updateMtime()
 		this._data.size = size
 	}
@@ -254,6 +257,7 @@ export abstract class Node {
 	 * Set the file permissions
 	 */
 	set permissions(permissions: Permission) {
+		validateData({ ...this._data, permissions }, this._knownDavService)
 		this.updateMtime()
 		this._data.permissions = permissions
 	}
@@ -341,6 +345,7 @@ export abstract class Node {
 	 * Set the node status.
 	 */
 	set status(status: NodeStatus|undefined) {
+		validateData({ ...this._data, status }, this._knownDavService)
 		this._data.status = status
 	}