fix(node): cloning

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

Author: skjnldsv

lib/node/file.ts

@@ -15,7 +15,7 @@ export class File extends Node {
 	 * Returns a clone of the file
 	 */
 	clone(): File {
-		return new File(this.data)
+		return new File(structuredClone(this._data), this._knownDavService)
 	}
 
 }

lib/node/folder.ts

@@ -2,18 +2,17 @@
  * SPDX-FileCopyrightText: 2022 Nextcloud GmbH and Nextcloud contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
-import type { NodeData } from './nodeData'
 import { FileType } from './fileType'
 import { Node } from './node'
 
 export class Folder extends Node {
 
-	constructor(data: NodeData) {
+	constructor(...[data, davService]: ConstructorParameters<typeof Node>) {
 		// enforcing mimes
 		super({
 			...data,
 			mime: 'httpd/unix-directory',
-		})
+		}, davService)
 	}
 
 	get type(): FileType.Folder {
@@ -32,7 +31,7 @@ export class Folder extends Node {
 	 * Returns a clone of the folder
 	 */
 	clone(): Folder {
-		return new Folder(this.data)
+		return new Folder(structuredClone(this._data), this._knownDavService)
 	}
 
 }

lib/node/node.ts

@@ -7,7 +7,7 @@ import { encodePath } from '@nextcloud/paths'
 
 import { Permission } from '../permissions'
 import { FileType } from './fileType'
-import { Attribute, isDavResource, NodeData, validateData } from './nodeData'
+import { Attribute, fixDates, fixRegExp, isDavResource, NodeData, validateData } from './nodeData'
 import logger from '../utils/logger'
 
 export enum NodeStatus {
@@ -21,11 +21,14 @@ export enum NodeStatus {
 	LOCKED = 'locked',
 }
 
+type NodeConstructorData = [NodeData, RegExp?]
+
 export abstract class Node {
 
-	private _data: NodeData
 	private _attributes: Attribute
-	private _knownDavService = /(remote|public)\.php\/(web)?dav/i
+
+	protected _data: NodeData
+	protected _knownDavService = /(remote|public)\.php\/(web)?dav/i
 
 	private readonlyAttributes = Object.entries(Object.getOwnPropertyDescriptors(Node.prototype))
 		.filter(e => typeof e[1].get === 'function' && e[0] !== '__proto__')
@@ -58,13 +61,17 @@ export abstract class Node {
 		},
 	} as ProxyHandler<Attribute>
 
-	constructor(data: NodeData, davService?: RegExp) {
+	protected constructor(...[data, davService]: NodeConstructorData) {
 		if (!data.mime) {
 			data.mime = 'application/octet-stream'
 		}
 
+		// Fix primitive types if needed
+		fixDates(data)
+		davService = fixRegExp(davService || this._knownDavService)
+
 		// Validate data
-		validateData(data, davService || this._knownDavService)
+		validateData(data, davService)
 
 		this._data = {
 			// TODO: Remove with next major release, this is just for compatibility
@@ -346,13 +353,6 @@ export abstract class Node {
 		this._data.status = status
 	}
 
-	/**
-	 * Get the node data
-	 */
-	get data(): NodeData {
-		return structuredClone(this._data)
-	}
-
 	/**
 	 * Move the node to a new destination
 	 *
@@ -424,7 +424,17 @@ export abstract class Node {
 	/**
 	 * Returns a clone of the node
 	 */
-	abstract clone(): Node
+	clone(): this {
+		// @ts-expect-error -- this class is abstract and cannot be instantiated directly but all its children can
+		return new this.constructor(structuredClone(this._data), this._knownDavService)
+	}
+
+	/**
+	 * JSON representation of the node
+	 */
+	toJSON(): string {
+		return JSON.stringify([structuredClone(this._data), this._knownDavService.toString()])
+	}
 
 }