fix(actions): reduce context of displayName, title, iconSvgInline, inline and renderInline

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

Author: skjnldsv

__tests__/actions/fileAction.spec.ts

@@ -249,17 +249,17 @@ describe('FileActions creation', () => {
 		const node = {} as Node
 
 		expect(action.id).toBe('test')
-		expect(action.displayName({ view, folder, nodes: [], content: [] })).toBe('Test')
-		expect(action.title?.({ view, folder, nodes: [], content: [] })).toBe('Test title')
-		expect(action.iconSvgInline({ view, folder, nodes: [], content: [] })).toBe('<svg></svg>')
+		expect(action.displayName({ view, nodes: [] })).toBe('Test')
+		expect(action.title?.({ view, nodes: [] })).toBe('Test title')
+		expect(action.iconSvgInline({ view, nodes: [] })).toBe('<svg></svg>')
 		await expect(action.exec({ view, folder, nodes: [node], content: [] })).resolves.toBe(true)
 		await expect(action.execBatch?.({ view, folder, nodes: [], content: [] })).resolves.toStrictEqual([true])
 		expect(action.enabled?.({ view, folder, nodes: [], content: [] })).toBe(true)
 		expect(action.order).toBe(100)
 		expect(action.parent).toBe('123')
 		expect(action.destructive).toBe(true)
 		expect(action.default).toBe(DefaultType.DEFAULT)
-		expect(action.inline?.({ view, folder, nodes: [], content: [] })).toBe(true)
-		expect((await action.renderInline?.({ view, folder, nodes: [], content: [] }))?.outerHTML).toBe('<span>test</span>')
+		expect(action.inline?.({ view, nodes: [] })).toBe(true)
+		expect((await action.renderInline?.({ view, nodes: [] }))?.outerHTML).toBe('<span>test</span>')
 	})
 })

lib/actions/fileAction.ts

@@ -2,7 +2,7 @@
  * SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
-import type { ActionContext, ActionContextSingle } from '../types.ts'
+import type { ActionContext, ActionContextBase, ActionContextSingle } from '../types.ts'
 
 import logger from '../utils/logger.ts'
 
@@ -46,11 +46,11 @@ export interface FileActionData {
 	/** Unique ID */
 	id: string
 	/** Translatable string displayed in the menu */
-	displayName: (context: ActionContext) => string
+	displayName: (context: ActionContextBase) => string
 	/** Translatable title for of the action */
-	title?: (context: ActionContext) => string
+	title?: (context: ActionContextBase) => string
 	/** Svg as inline string. <svg><path fill="..." /></svg> */
-	iconSvgInline: (context: ActionContext) => string
+	iconSvgInline: (context: ActionContextBase) => string
 	/** Condition wether this action is shown or not */
 	enabled?: (context: ActionContext) => boolean
 
@@ -102,12 +102,12 @@ export interface FileActionData {
 	/**
 	 * If true, the renderInline function will be called
 	 */
-	inline?: (context: ActionContext) => boolean,
+	inline?: (context: ActionContextBase) => boolean,
 	/**
 	 * If defined, the returned html element will be
 	 * appended before the actions menu.
 	 */
-	renderInline?: (context: ActionContext) => Promise<HTMLElement | null>,
+	renderInline?: (context: ActionContextBase) => Promise<HTMLElement | null>,
 }
 
 export class FileAction {

lib/types.ts

@@ -6,19 +6,19 @@
 import { Folder, Node } from './node/index.ts'
 import { View } from './navigation/index.ts'
 
-export type ActionContextSingle = {
-	nodes: [Node],
+export type ActionContextBase = {
+	nodes: Node[],
 	view: View,
-	folder: Folder,
-	content: Node[],
 }
 
 export type ActionContext = {
-	nodes: Node[],
-	view: View,
 	folder: Folder,
 	content: Node[],
-}
+} & ActionContextBase
+
+export type ActionContextSingle = {
+	nodes: [Node],
+} & ActionContext
 
 export type ViewActionContext = {
 	view: View,