refactor!(navigation): pass id of view to setActive

This ensures only registered views can be set as active.
Otherwise one could set unknown views as active.
Additionally this ensures that all views the navigation handles are
validated in `registerView`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Author: susnux

__tests__/navigation.spec.ts

@@ -109,7 +109,7 @@ describe('Navigation', () => {
 
 		expect(navigation.active).toBe(null)
 
-		navigation.setActive(view)
+		navigation.setActive(view.id)
 		expect(navigation.active).toEqual(view)
 	})
 
@@ -122,9 +122,25 @@ describe('Navigation', () => {
 		const listener = vi.fn()
 		navigation.addEventListener('updateActive', listener)
 
-		navigation.setActive(view)
+		navigation.setActive(view.id)
 		expect(listener).toHaveBeenCalledOnce()
 		// So it was called, we then expect the first argument of the first call to be the event with the view as the detail
 		expect(listener.mock.calls[0][0].detail).toBe(view)
 	})
+
+	it('Can unset the active view', async () => {
+		const navigation = new Navigation()
+		const { view } = mockView()
+		navigation.register(view)
+		navigation.setActive(view.id)
+		expect(navigation.active).toEqual(view)
+
+		navigation.setActive(null)
+		expect(navigation.active).toBeNull()
+	})
+
+	it('Throws when there is no view to set active', () => {
+		const navigation = new Navigation()
+		expect(() => navigation.setActive('does not exist')).toThrowError()
+	})
 })

lib/navigation/navigation.ts

@@ -81,12 +81,23 @@ export class Navigation extends TypedEventTarget<{ updateActive: UpdateActiveVie
 
 	/**
 	 * Set the currently active view
+	 *
+	 * @param id - The id of the view to set as active
+	 * @throws {Error} If no view with the given id was registered
 	 * @fires UpdateActiveViewEvent
-	 * @param view New active view
 	 */
-	setActive(view: IView | null): void {
-		this._currentView = view
-		const event = new CustomEvent<IView | null>('updateActive', { detail: view })
+	setActive(id: string | null): void {
+		if (id === null) {
+			this._currentView = null
+		} else {
+			const view = this._views.find(({ id: viewId }) => viewId === id)
+			if (!view) {
+				throw new Error(`No view with ${id} registered`)
+			}
+			this._currentView = view
+		}
+
+		const event = new CustomEvent<IView | null>('updateActive', { detail: this._currentView })
 		this.dispatchTypedEvent('updateActive', event as UpdateActiveViewEvent)
 	}